Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2274713002: Do not update stats for WebRTC.Call.EstimatedSendBitrateInKbps if we are not sending video (Closed)

Created:
4 years, 4 months ago by perkj_webrtc
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not update stats for WebRTC.Call.EstimatedSendBitrateInKbps if we are not sending video. This hopefully fixes a UMA stats regression introduced in https://chromium.googlesource.com/external/webrtc/+/71ee44cc6d3049763da69e8e42a08d4b796b97db BUG=webrtc:6244 TBR=stefan@webrtc.org Committed: https://crrev.com/5bed20f7c67c54940ca53bbcfc2c6be3dd3e6149 Cr-Commit-Position: refs/heads/master@{#13868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/call/call.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
perkj_webrtc
4 years, 4 months ago (2016-08-23 19:51:30 UTC) #2
perkj_webrtc
please
4 years, 4 months ago (2016-08-23 19:58:52 UTC) #8
perkj_webrtc
4 years, 4 months ago (2016-08-23 20:00:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5bed20f7c67c54940ca53bbcfc2c6be3dd3e6149 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698