Combining "SetTransportChannel" and "SetRtcpTransportChannel".

Combining "SetTransportChannel" and "SetRtcpTransportChannel".

The only real difference between the two is that SetRtcpTransportChannel
had a workaround to prevent a signal from being emitted early.
Basically, in SetTransport, we want to switch the transport channels and
*then* update the state, rather than updating the state after changing
only one transport channel.

But this can be accomplished more easily by simply updating the state in
SetTransport directly.

Committed: https://crrev.com/062ce9fe3a1d8344bcbd6eedba9ec24eac9d3d3d
Cr-Commit-Position: refs/heads/master@{#13945}

[skvlad, 2016-08-26 23:23:12]

skvlad@webrtc.org changed reviewers:
+ skvlad@webrtc.org

[skvlad, 2016-08-26 23:23:13]

lgtm

https://codereview.webrtc.org/2274283004/diff/1/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/2274283004/diff/1/webrtc/pc/channel.cc#newcode1209
webrtc/pc/channel.cc:1209: SetTransportChannelReadyToSend(true, false);
Please add comments for what the "true" /* rtcp */ and "false" /* ready_to_send
*/ parameters mean.

In general the use of a boolean to choose between the RTP and RTCP channels in
this file makes it very hard to read. Perhaps we can use an enum, or group the
channel states together into a struct (one for RTP and one for RTCP) and pass
around a pointer to that struct. But this is not related to this CL, please
don't spend time on it yet.

[Taylor Brandstetter, 2016-08-26 23:29:40]

https://codereview.webrtc.org/2274283004/diff/1/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/2274283004/diff/1/webrtc/pc/channel.cc#newcode1209
webrtc/pc/channel.cc:1209: SetTransportChannelReadyToSend(true, false);
On 2016/08/26 23:23:13, skvlad wrote:
> Please add comments for what the "true" /* rtcp */ and "false" /*
ready_to_send
> */ parameters mean.
> 
> In general the use of a boolean to choose between the RTP and RTCP channels in
> this file makes it very hard to read. Perhaps we can use an enum, or group the
> channel states together into a struct (one for RTP and one for RTCP) and pass
> around a pointer to that struct. But this is not related to this CL, please
> don't spend time on it yet.

I agree. I was planning to use an enum; the struct idea is good too.

[Taylor Brandstetter, 2016-08-26 23:29:48]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-08-26 23:29:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-26 23:40:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 23:40:18]

Try jobs failed on following builders:
  linux_ubsan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/4448)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/17581)

[Taylor Brandstetter, 2016-08-27 04:10:25]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-08-27 04:10:25]

The patchset sent to the CQ was uploaded after l-g-t-m from skvlad@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2274283004/#ps20001 (title:
"Set correct socket options.")

[commit-bot: I haz the power, 2016-08-27 04:10:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-27 04:42:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-27 04:42:28]

Description was changed from

==========
Combining "SetTransportChannel" and "SetRtcpTransportChannel".

The only real difference between the two is that SetRtcpTransportChannel
had a workaround to prevent a signal from being emitted early.
Basically, in SetTransport, we want to switch the transport channels and
*then* update the state, rather than updating the state after changing
only one transport channel.

But this can be accomplished more easily by simply updating the state in
SetTransport directly.
==========

to

==========
Combining "SetTransportChannel" and "SetRtcpTransportChannel".

The only real difference between the two is that SetRtcpTransportChannel
had a workaround to prevent a signal from being emitted early.
Basically, in SetTransport, we want to switch the transport channels and
*then* update the state, rather than updating the state after changing
only one transport channel.

But this can be accomplished more easily by simply updating the state in
SetTransport directly.

Committed: https://crrev.com/062ce9fe3a1d8344bcbd6eedba9ec24eac9d3d3d
Cr-Commit-Position: refs/heads/master@{#13945}
==========

[commit-bot: I haz the power, 2016-08-27 04:42:29]

Patchset 2 (id:??) landed as
https://crrev.com/062ce9fe3a1d8344bcbd6eedba9ec24eac9d3d3d
Cr-Commit-Position: refs/heads/master@{#13945}