Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: webrtc/api/android/java/src/org/webrtc/VideoFileRenderer.java

Issue 2273573003: Support for video file instead of camera and output video out to file (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing review comments, except unittesting Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/android/java/src/org/webrtc/VideoFileRenderer.java
diff --git a/webrtc/api/android/java/src/org/webrtc/VideoFileRenderer.java b/webrtc/api/android/java/src/org/webrtc/VideoFileRenderer.java
new file mode 100644
index 0000000000000000000000000000000000000000..afb19b3809ee672e4c6736609fa7e169a791d362
--- /dev/null
+++ b/webrtc/api/android/java/src/org/webrtc/VideoFileRenderer.java
@@ -0,0 +1,153 @@
+/*
+ * Copyright 2016 The WebRTC Project Authors. All rights reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+package org.webrtc;
+
+import android.os.Handler;
+import android.os.HandlerThread;
+
+import java.nio.ByteBuffer;
+import java.io.FileOutputStream;
+import java.io.IOException;
+
+/**
+ * Can be used to saves the video frames to file.
+ */
+public class VideoFileRenderer implements VideoRenderer.Callbacks {
+ private static final String TAG = "VideoFileRenderer";
+
+ private SurfaceTextureHelper.YuvConverter yuvConverter;
sakal 2016/10/05 13:28:41 final
+ private HandlerThread renderThread;
sakal 2016/10/05 13:28:41 final
+ private Handler renderThreadHandler;
sakal 2016/10/05 13:28:41 final
+ private FileOutputStream videoOutFile;
sakal 2016/10/05 13:28:41 final
+ private int outputFileWidth;
sakal 2016/10/05 13:28:41 final
+ private int outputFileHeight;
sakal 2016/10/05 13:28:40 final
+ private int outputFrameSize;
sakal 2016/10/05 13:28:41 final
+ private ByteBuffer outputFrameBuffer;
sakal 2016/10/05 13:28:41 final
+
+ public VideoFileRenderer(
+ String outputFile, int outputFileWidth, int outputFileHeight,
+ EglBase.Context sharedContext) throws IOException {
+ if ((outputFileWidth % 2) == 1 || (outputFileHeight % 2) == 1) {
+ throw new IllegalArgumentException("Does not support uneven width or height");
+ }
+ yuvConverter = new SurfaceTextureHelper.YuvConverter(sharedContext);
+
+ this.outputFileWidth = outputFileWidth;
+ this.outputFileHeight = outputFileHeight;
+
+ outputFrameSize = outputFileWidth * outputFileHeight * 3 / 2;
+ outputFrameBuffer = ByteBuffer.allocateDirect(outputFrameSize);
+
+ videoOutFile = new FileOutputStream(outputFile);
+ videoOutFile.write((
+ "YUV4MPEG2 C420 W" + outputFileWidth +
+ " H" + outputFileHeight + " Ip F30:1 A1:1\n").getBytes());
+
+ renderThread = new HandlerThread(TAG);
+ renderThread.start();
+ renderThreadHandler = new Handler(renderThread.getLooper());
+ }
+
+ @Override
+ public void renderFrame(final VideoRenderer.I420Frame frame) {
+ renderThreadHandler.post(new Runnable() {
+ @Override
+ public void run() {
+ renderFrameOnRenderThread(frame);
+ }
+ });
+ }
+
+ private void renderFrameOnRenderThread(VideoRenderer.I420Frame frame) {
+ float frameAspectRatio = (frame.rotationDegree % 180 == 0) ?
+ (float) frame.width / frame.height
+ : (float) frame.height / frame.width;
+
+ final float[] rotatedSamplingMatrix = RendererCommon.rotateTextureMatrix(
+ frame.samplingMatrix, frame.rotationDegree);
+ final float[] layoutMatrix = RendererCommon.getLayoutMatrix(
+ false, frameAspectRatio, (float) outputFileWidth / outputFileHeight);
+ final float[] texMatrix = RendererCommon.multiplyMatrices(
+ rotatedSamplingMatrix, layoutMatrix);
+
+ int oesTextureId = frame.textureId;
sakal 2016/10/05 13:28:41 nit: I don't see why you need this variable
mandermo 2016/10/07 11:33:40 Removed and using frame.textureId instead of oesTe
+
+ if (!frame.yuvFrame) {
+ yuvConverter.convert(
+ outputFrameBuffer, outputFileWidth, outputFileHeight, outputFileWidth,
+ oesTextureId, texMatrix);
+
+ VideoRenderer.renderFrameDone(frame);
+
+ try {
+ videoOutFile.write("FRAME\n".getBytes());
+
+ int width = outputFileWidth;
sakal 2016/10/05 13:28:41 nit: I'd prefer removing these width/height variab
mandermo 2016/10/07 11:33:40 Done.
+ int height = outputFileHeight;
+ int stride = width;
+ byte[] data = outputFrameBuffer.array();
+ int offset = outputFrameBuffer.arrayOffset();
+
+ Logging.d(TAG,
+ "arrayOffset(): " + outputFrameBuffer.arrayOffset() +
+ " hasArray: " + outputFrameBuffer.hasArray());
+ // Write Y
+ videoOutFile.write(data, offset, width * height);
+
+ // Write U
+ for (int r = height; r<height * 3 / 2; ++r) {
sakal 2016/10/05 13:28:41 nit: why r instead of more standard i?
sakal 2016/10/05 13:28:41 Add spaces around <
mandermo 2016/10/07 11:33:40 It is r for row. Should I change to i or add comme
+ videoOutFile.write(data, offset + r * stride, stride / 2);
+ }
+
+ // Write V
+ for (int r = height; r<height * 3 / 2; ++r) {
sakal 2016/10/05 13:28:41 ditto
mandermo 2016/10/07 11:33:40 Done.
+ videoOutFile.write(data, offset + r * stride + stride / 2, stride / 2);
+ }
+ } catch (IOException e) {
+ Logging.d(TAG, "Failed to write to file for video out");
sakal 2016/10/05 13:28:40 Logging.e
+ }
+ } else {
+ try {
+ videoOutFile.write("FRAME\n".getBytes());
+
+ nativeI420Scale(
+ frame.yuvPlanes[0], frame.yuvStrides[0],
+ frame.yuvPlanes[1], frame.yuvStrides[1],
+ frame.yuvPlanes[2], frame.yuvStrides[2],
+ frame.width, frame.height,
+ outputFrameBuffer, outputFileWidth, outputFileHeight);
+ videoOutFile.write(
+ outputFrameBuffer.array(),
+ outputFrameBuffer.arrayOffset(),
+ outputFrameSize);
+ } catch (IOException e) {
+ Logging.d(TAG, "Failed to write to file for video out");
+ throw new RuntimeException(e);
+ } finally {
+ VideoRenderer.renderFrameDone(frame);
+ }
+ }
+ }
+
+ public void release() {
+ try {
+ videoOutFile.close();
+ } catch (IOException e) {
+ Logging.d(TAG, "Error closing output video file");
sakal 2016/10/05 13:28:41 Logging.e
mandermo 2016/10/07 11:33:40 Done.
+ }
+ }
+
+ public static native void nativeI420Scale(
+ ByteBuffer srcY, int strideY,
+ ByteBuffer srcU, int strideU,
+ ByteBuffer srcV, int strideV,
+ int width, int height, ByteBuffer dst, int dstWidth, int dstHeight);
+}
+

Powered by Google App Engine
This is Rietveld 408576698