Extract library from the RTCEventLog visualizer

webrtc/tools/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//testing/test.gni")
 import("../build/webrtc.gni")
@@ skipping 156 matching lines @@
   testonly = true
   sources = [
     "agc/test_utils.cc",
     "agc/test_utils.h",
   ]
 
   configs += [ "..:common_config" ]
   public_configs = [ "..:common_inherited_config" ]
 }
 
+if (rtc_enable_protobuf) {
+  source_set("event_log_visualizer_utils") {

[terelius, 2016/08/23 02:55:20]

Should this be testonly too? The webrtc static library is not supposed to depend
on it. On the other hand, external visualization tools might want to depend on
it without being marked as testonly.

[kjellander_webrtc, 2016/08/23 05:52:06]

I guess it's fine leaving it without testonly.

+    sources = [
+      "event_log_visualizer/analyzer.cc",
+      "event_log_visualizer/analyzer.h",
+      "event_log_visualizer/plot_base.cc",
+      "event_log_visualizer/plot_base.h",
+      "event_log_visualizer/plot_python.cc",
+      "event_log_visualizer/plot_python.h",
+    ]
+    configs += [ "..:common_config" ]
+    public_configs = [ "..:common_inherited_config" ]
+    if (is_clang && !is_nacl) {
+      # Suppress warnings from the Chromium Clang plugin.
+      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+      configs -= [ "//build/config/clang:find_bad_constructs" ]

[kjellander_webrtc, 2016/08/23 05:52:06]

I'd be very happy if these warnings could be fixed instead of suppressed. Is
that possible?

+    }
+    defines = [ "ENABLE_RTC_EVENT_LOG" ]
+    deps = [
+      "../:rtc_event_log",
+      "../:rtc_event_log_parser",
+      "../modules/congestion_controller:congestion_controller",
+      "../modules/rtp_rtcp:rtp_rtcp",
+      "../system_wrappers:system_wrappers_default",
+      "//build/config/sanitizers:deps",
+    ]
+    public_deps = [
+      "../:rtc_event_log_parser",
+    ]
+  }
+}
+
 # Exclude tools depending on gflags since that's not available in Chromium.
 if (rtc_include_tests) {
   if (rtc_enable_protobuf) {
     executable("event_log_visualizer") {
       testonly = true
       sources = [
-        "event_log_visualizer/analyzer.cc",
-        "event_log_visualizer/analyzer.h",
         "event_log_visualizer/main.cc",
-        "event_log_visualizer/plot_base.cc",
-        "event_log_visualizer/plot_base.h",
-        "event_log_visualizer/plot_python.cc",
-        "event_log_visualizer/plot_python.h",
       ]
 
       configs += [ "..:common_config" ]
       public_configs = [ "..:common_inherited_config" ]
 
       if (is_clang && !is_nacl) {
         # Suppress warnings from the Chromium Clang plugin.
         # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
         configs -= [ "//build/config/clang:find_bad_constructs" ]
       }
 
       defines = [ "ENABLE_RTC_EVENT_LOG" ]
       deps = [
-        "../:rtc_event_log",
-        "../:rtc_event_log_parser",
-        "../modules/congestion_controller:congestion_controller",
-        "../modules/rtp_rtcp:rtp_rtcp",
-        "../system_wrappers:system_wrappers_default",
-        "../test:field_trial",
+        ":event_log_visualizer_utils",
         "//build/config/sanitizers:deps",
         "//third_party/gflags",
       ]
     }
   }
 
   executable("agc_harness") {
     testonly = true
     sources = [
       "agc/agc_harness.cc",
@@ skipping 118 matching lines @@
       ]
       outputs = [
         "$root_build_dir/{{source_file_part}}",
       ]
       deps = [
         "..:rtc_event_log_proto",
       ]
     }
   }
 }