Extract library from the RTCEventLog visualizer

Extract library from the RTCEventLog visualizer

This change splits the RtcEventLog visualization tool into a library and
the command-line tool that drives it. This allows other applications to
link with the library.

BUG=6249
R=kjellander@webrtc.org, terelius@webrtc.org

Committed: https://crrev.com/185ba29a3c0556798158840c2424416d0fd779fe
Cr-Commit-Position: refs/heads/master@{#13869}

[skvlad, 2016-08-23 02:31:29]

skvlad@webrtc.org changed reviewers:
+ kjellander@webrtc.org, terelius@webrtc.org

[terelius, 2016-08-23 02:55:20]

https://codereview.webrtc.org/2273473002/diff/20001/webrtc/tools/BUILD.gn
File webrtc/tools/BUILD.gn (right):

https://codereview.webrtc.org/2273473002/diff/20001/webrtc/tools/BUILD.gn#new...
webrtc/tools/BUILD.gn:178: source_set("event_log_visualizer_utils") {
Should this be testonly too? The webrtc static library is not supposed to depend
on it. On the other hand, external visualization tools might want to depend on
it without being marked as testonly.

[kjellander_webrtc, 2016-08-23 05:52:06]

lgtm

https://codereview.webrtc.org/2273473002/diff/20001/webrtc/tools/BUILD.gn
File webrtc/tools/BUILD.gn (right):

https://codereview.webrtc.org/2273473002/diff/20001/webrtc/tools/BUILD.gn#new...
webrtc/tools/BUILD.gn:178: source_set("event_log_visualizer_utils") {
On 2016/08/23 02:55:20, terelius wrote:
> Should this be testonly too? The webrtc static library is not supposed to
depend
> on it. On the other hand, external visualization tools might want to depend on
> it without being marked as testonly.

I guess it's fine leaving it without testonly.

https://codereview.webrtc.org/2273473002/diff/20001/webrtc/tools/BUILD.gn#new...
webrtc/tools/BUILD.gn:192: configs -= [
"//build/config/clang:find_bad_constructs" ]
I'd be very happy if these warnings could be fixed instead of suppressed. Is
that possible?

[terelius, 2016-08-23 16:07:56]

lgtm

[skvlad, 2016-08-23 17:50:16]

Description was changed from

==========
Extract library from the RTCEventLog visualizer

This change splits the RtcEventLog visualization tool into a library and
the command-line tool that drives it. This allows other applications to
link with the library.
==========

to

==========
Extract library from the RTCEventLog visualizer

This change splits the RtcEventLog visualization tool into a library and
the command-line tool that drives it. This allows other applications to
link with the library.

BUG=6249
==========

[skvlad, 2016-08-23 17:53:54]

The CQ bit was checked by skvlad@webrtc.org

[commit-bot: I haz the power, 2016-08-23 17:53:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-23 19:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 19:54:35]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[skvlad, 2016-08-23 20:01:41]

Description was changed from

==========
Extract library from the RTCEventLog visualizer

This change splits the RtcEventLog visualization tool into a library and
the command-line tool that drives it. This allows other applications to
link with the library.

BUG=6249
==========

to

==========
Extract library from the RTCEventLog visualizer

This change splits the RtcEventLog visualization tool into a library and
the command-line tool that drives it. This allows other applications to
link with the library.

BUG=6249
R=kjellander@webrtc.org, terelius@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/185ba29a3c0556798158840c2...
==========

[skvlad, 2016-08-23 20:01:42]

Committed patchset #2 (id:20001) manually as
185ba29a3c0556798158840c2424416d0fd779fe (presubmit successful).

[commit-bot: I haz the power, 2016-08-23 20:01:46]

Description was changed from

==========
Extract library from the RTCEventLog visualizer

This change splits the RtcEventLog visualization tool into a library and
the command-line tool that drives it. This allows other applications to
link with the library.

BUG=6249
R=kjellander@webrtc.org, terelius@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/185ba29a3c0556798158840c2...
==========

to

==========
Extract library from the RTCEventLog visualizer

This change splits the RtcEventLog visualization tool into a library and
the command-line tool that drives it. This allows other applications to
link with the library.

BUG=6249
R=kjellander@webrtc.org, terelius@webrtc.org

Committed: https://crrev.com/185ba29a3c0556798158840c2424416d0fd779fe
Cr-Commit-Position: refs/heads/master@{#13869}
==========