Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2272563010: AbsoluteSendTime rtp header extension publish MsTo24Bit conversion (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AbsoluteSendTime rtp header extension publish MsTo24Bit conversion Since this conversion is used in multiple place and extension seems right place to keep it in. BUG=webrtc:1994 NOTRY=true Committed: https://crrev.com/a897f26f1729699628426d47f6615f77f2399b94 Cr-Commit-Position: refs/heads/master@{#13934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
danilchap
4 years, 3 months ago (2016-08-25 17:19:49 UTC) #2
philipel
lgtm
4 years, 3 months ago (2016-08-26 11:08:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2272563010/1
4 years, 3 months ago (2016-08-26 12:34:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 12:42:44 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 12:42:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a897f26f1729699628426d47f6615f77f2399b94
Cr-Commit-Position: refs/heads/master@{#13934}

Powered by Google App Engine
This is Rietveld 408576698