Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2272003002: Moved format_macros.h from rtc_base to rtc_base_approved. (Closed)

Created:
4 years, 4 months ago by ivoc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved format_macros.h from rtc_base to rtc_base_approved. BUG=webrtc:3806 NOTRY=True Committed: https://crrev.com/48052316130d8ba98ccfe748179013a633e3cbf7 Cr-Commit-Position: refs/heads/master@{#13921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/base/base.gyp View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isac_test.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
ivoc
Hi Henrik, please have a look.
4 years, 4 months ago (2016-08-24 13:29:43 UTC) #3
kjellander_webrtc
lgtm I think you can run just a few compile bots and set NOTRY=True for ...
4 years, 4 months ago (2016-08-24 14:42:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2272003002/1
4 years, 3 months ago (2016-08-25 11:34:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 11:43:49 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:43:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48052316130d8ba98ccfe748179013a633e3cbf7
Cr-Commit-Position: refs/heads/master@{#13921}

Powered by Google App Engine
This is Rietveld 408576698