Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2271433002: Fixing TSan data race warning in video end-to-end tests. (Closed)

Created:
4 years, 4 months ago by Taylor Brandstetter
Modified:
4 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing TSan data race warning in video end-to-end tests. Needed to use critical section in "SendRtp"/"SendRtcp", which is what the real implementation ultimately does. TBR=stefan@webrtc.org Committed: https://crrev.com/14cf12b1eaf6155dc474c68c5562597157c65b01 Cr-Commit-Position: refs/heads/master@{#13857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Taylor Brandstetter
PTAL. Here's an example of a test that failed for this reason: https://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan%20v2/builds/7508/steps/video_engine_tests/logs/stdio
4 years, 4 months ago (2016-08-22 22:45:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2271433002/1
4 years, 4 months ago (2016-08-22 22:45:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-23 00:45:59 UTC) #7
Taylor Brandstetter
4 years, 4 months ago (2016-08-23 01:14:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14cf12b1eaf6155dc474c68c5562597157c65b01 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698