Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2271203003: Fixing timestamp comparison assert. (Closed)

Created:
4 years, 4 months ago by Taylor Brandstetter
Modified:
4 years, 4 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing timestamp comparison assert. Wasn't handling wrap-around properly. Noticed this because a test failed. TBR=henrik.lundin@webrtc.org Committed: https://crrev.com/fcada904857e066a202e5f4cff92cb9c4de8fca4 Cr-Commit-Position: refs/heads/master@{#13905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Taylor Brandstetter
4 years, 4 months ago (2016-08-24 17:31:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2271203003/1
4 years, 4 months ago (2016-08-24 17:31:52 UTC) #5
hlundin-webrtc
Awesome! LGTM.
4 years, 4 months ago (2016-08-24 17:33:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 19:45:17 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 19:45:28 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fcada904857e066a202e5f4cff92cb9c4de8fca4
Cr-Commit-Position: refs/heads/master@{#13905}

Powered by Google App Engine
This is Rietveld 408576698