Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2270753002: Remove RtcpPacket dependency on rtcp_utility: (Closed)

Created:
4 years, 4 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove RtcpPacket dependency on rtcp_utility and thus IP_PACKET_SIZE constant: Build() use BlockLength() instead of constant IP_PACKET_SIZE for packet capacity, adding extra checks about packet generation in tests. Build(callback) removed as unused. definitions reordered to follow style. BUG=webrtc:5260 Committed: https://crrev.com/c1f40b7bae66f3eaba4f0edccf26a1283fa2e4ee Cr-Commit-Position: refs/heads/master@{#14647}

Patch Set 1 #

Patch Set 2 : Removed byte_io.h include, added some explicetness #

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -61 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 2 3 chunks +13 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 1 2 4 chunks +22 lines, -44 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
danilchap
4 years, 3 months ago (2016-09-21 17:15:43 UTC) #5
sprang_webrtc
lgtm
4 years, 2 months ago (2016-10-17 08:13:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2270753002/60001
4 years, 2 months ago (2016-10-17 08:14:15 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-17 08:44:47 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 08:44:52 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c1f40b7bae66f3eaba4f0edccf26a1283fa2e4ee
Cr-Commit-Position: refs/heads/master@{#14647}

Powered by Google App Engine
This is Rietveld 408576698