Migrated ILBC and ISAC test targets for GN.

webrtc/modules/audio_coding/BUILD.gn

Index: webrtc/modules/audio_coding/BUILD.gn
diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn
index 9d426e9ab1f0ad35fc86a64d16d405dff52b30c1..d6d52cb2bba940d01ff745ea65cf30d61c866775 100644
--- a/webrtc/modules/audio_coding/BUILD.gn
+++ b/webrtc/modules/audio_coding/BUILD.gn
@@ -541,6 +541,7 @@ source_set("isac") {
     ":audio_decoder_interface",
     ":audio_encoder_interface",
     ":isac_common",
+    "../..:webrtc_common",
     "../../common_audio",
   ]
 }
@@ -1582,6 +1583,7 @@ if (rtc_include_tests) {
 
     deps = [
       ":g711",
+      "//build/config/sanitizers:deps",

[aleloi, 2016/08/24 11:02:51]

Added dependence to :isac in order for it to pass gn check

     ]
   }
 
@@ -1598,6 +1600,62 @@ if (rtc_include_tests) {
     deps = [
       ":g722",
       "../..:webrtc_common",
+      "//build/config/sanitizers:deps",

[aleloi, 2016/08/24 11:02:51]

Added sanitizers deps to executable.

+    ]
+  }
+
+  executable("isac_api_test") {
+    testonly = true
+
+    sources = [
+      "codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc",
+      "codecs/isac/main/util/utility.c",
+    ]
+
+    deps = [

[kjellander_webrtc, 2016/08/26 14:07:37]

For all three targets, please add:

configs += [ "../..:common_config" ]
public_configs = [ "../..:common_inherited_config" ]

It'll go away as soon we've figure out how to use GN templates for it, but for
now it should be used for all targets (although it may not be needed for these,
it's better to be safe so all the right defines are set for the code).

+      ":isac",
+      "../../base:rtc_base",

[aleloi, 2016/08/24 11:02:51]

'Forbidden' dependency; also added matching dependency in gyp files.

[kjellander_webrtc, 2016/08/26 14:07:37]

Do you need rtc_base or is rtc_base_approved enough? (preferred)

[aleloi, 2016/08/29 09:39:10]

Yes, rtc_base is needed. Specifically webrtc/base/format_macros.h

[aleloi, 2016/08/29 10:57:29]

Actually, ivoc@ broke out format_macros.h from rtc_base, and now I can depend on
base_approved. I uploaded a new patch set.

+      "//build/config/sanitizers:deps",
+    ]
+
+    include_dirs = [
+      "codecs/isac/main/test",
+      "codecs/isac/main/include",

[kjellander_webrtc, 2016/08/26 14:07:37]

nit: sort includes

[aleloi, 2016/08/29 09:39:10]

Done.

+      "codecs/isac/main/util",
+    ]
+  }
+
+  executable("isac_switch_samprate_test") {
+    testonly = true
+
+    sources = [
+      "codecs/isac/main/test/SwitchingSampRate/SwitchingSampRate.cc",
+      "codecs/isac/main/util/utility.c",
+    ]
+
+    deps = [
+      ":isac",
+      "//build/config/sanitizers:deps",
+    ]
+
+    include_dirs = [
+      "codecs/isac/main/test",
+      "codecs/isac/main/include",

[kjellander_webrtc, 2016/08/26 14:07:38]

nit: sort includes.

[aleloi, 2016/08/29 09:39:10]

Done.

+      "../../common_audio/signal_processing/include",
+      "codecs/isac/main/util",
+    ]
+  }
+
+  executable("ilbc_test") {
+    testonly = true
+
+    sources = [
+      "codecs/ilbc/test/iLBC_test.c",
+    ]
+
+    deps = [
+      ":ilbc",
+      "//build/config/sanitizers:deps",
     ]
   }
 }