Migrated ILBC and ISAC test targets for GN.

webrtc/modules/audio_coding/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../build/webrtc.gni")
 import("audio_coding.gni")
@@ skipping 523 matching lines @@
 
   public_configs = [
     "../..:common_inherited_config",
     ":isac_config",
   ]
 
   deps = [
     ":audio_decoder_interface",
     ":audio_encoder_interface",
     ":isac_common",
+    "../..:webrtc_common",
     "../../common_audio",
   ]
 }
 
 config("isac_fix_config") {
   include_dirs = [
     "../../..",
     "codecs/isac/fix/include",
   ]
 }
@@ skipping 1021 matching lines @@
 
     sources = [
       "codecs/g711/test/testG711.cc",
     ]
 
     configs += [ "../..:common_config" ]
     public_configs = [ "../..:common_inherited_config" ]
 
     deps = [
       ":g711",
+      "//build/config/sanitizers:deps",

[aleloi, 2016/08/24 11:02:51]

Added dependence to :isac in order for it to pass gn check

     ]
   }
 
   executable("g722_test") {
     testonly = true
 
     sources = [
       "codecs/g722/test/testG722.cc",
     ]
 
     configs += [ "../..:common_config" ]
     public_configs = [ "../..:common_inherited_config" ]
 
     deps = [
       ":g722",
       "../..:webrtc_common",
+      "//build/config/sanitizers:deps",

[aleloi, 2016/08/24 11:02:51]

Added sanitizers deps to executable.

+    ]
+  }
+
+  executable("isac_api_test") {
+    testonly = true
+
+    sources = [
+      "codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc",
+      "codecs/isac/main/util/utility.c",
+    ]
+
+    deps = [

[kjellander_webrtc, 2016/08/26 14:07:37]

For all three targets, please add:

configs += [ "../..:common_config" ]
public_configs = [ "../..:common_inherited_config" ]

It'll go away as soon we've figure out how to use GN templates for it, but for
now it should be used for all targets (although it may not be needed for these,
it's better to be safe so all the right defines are set for the code).

+      ":isac",
+      "../../base:rtc_base",

[aleloi, 2016/08/24 11:02:51]

'Forbidden' dependency; also added matching dependency in gyp files.

[kjellander_webrtc, 2016/08/26 14:07:37]

Do you need rtc_base or is rtc_base_approved enough? (preferred)

[aleloi, 2016/08/29 09:39:10]

Yes, rtc_base is needed. Specifically webrtc/base/format_macros.h

[aleloi, 2016/08/29 10:57:29]

Actually, ivoc@ broke out format_macros.h from rtc_base, and now I can depend on
base_approved. I uploaded a new patch set.

+      "//build/config/sanitizers:deps",
+    ]
+
+    include_dirs = [
+      "codecs/isac/main/test",
+      "codecs/isac/main/include",

[kjellander_webrtc, 2016/08/26 14:07:37]

nit: sort includes

[aleloi, 2016/08/29 09:39:10]

Done.

+      "codecs/isac/main/util",
+    ]
+  }
+
+  executable("isac_switch_samprate_test") {
+    testonly = true
+
+    sources = [
+      "codecs/isac/main/test/SwitchingSampRate/SwitchingSampRate.cc",
+      "codecs/isac/main/util/utility.c",
+    ]
+
+    deps = [
+      ":isac",
+      "//build/config/sanitizers:deps",
+    ]
+
+    include_dirs = [
+      "codecs/isac/main/test",
+      "codecs/isac/main/include",

[kjellander_webrtc, 2016/08/26 14:07:38]

nit: sort includes.

[aleloi, 2016/08/29 09:39:10]

Done.

+      "../../common_audio/signal_processing/include",
+      "codecs/isac/main/util",
+    ]
+  }
+
+  executable("ilbc_test") {
+    testonly = true
+
+    sources = [
+      "codecs/ilbc/test/iLBC_test.c",
+    ]
+
+    deps = [
+      ":ilbc",
+      "//build/config/sanitizers:deps",
     ]
   }
 }