Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: webrtc/stats/rtcstatscollector.h

Issue 2270033004: RTCStatsCollector collecting stats on multiple threads. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/stats/rtcstatscollector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_STATS_RTCSTATSCOLLECTOR_H_ 11 #ifndef WEBRTC_STATS_RTCSTATSCOLLECTOR_H_
12 #define WEBRTC_STATS_RTCSTATSCOLLECTOR_H_ 12 #define WEBRTC_STATS_RTCSTATSCOLLECTOR_H_
13 13
14 #include <memory> 14 #include <memory>
15 #include <vector>
15 16
16 #include "webrtc/api/rtcstats_objects.h" 17 #include "webrtc/api/rtcstats_objects.h"
17 #include "webrtc/api/rtcstatsreport.h" 18 #include "webrtc/api/rtcstatsreport.h"
19 #include "webrtc/base/asyncinvoker.h"
20 #include "webrtc/base/refcount.h"
18 #include "webrtc/base/scoped_ref_ptr.h" 21 #include "webrtc/base/scoped_ref_ptr.h"
19 #include "webrtc/base/timeutils.h" 22 #include "webrtc/base/timeutils.h"
20 23
21 namespace webrtc { 24 namespace webrtc {
22 25
23 class PeerConnection; 26 class PeerConnection;
24 27
25 // All calls to the collector and gathering of stats is performed on the 28 class RTCStatsCollectorCallback : public virtual rtc::RefCountInterface {
26 // signaling thread. A stats report is cached for |cache_lifetime_| ms.
27 class RTCStatsCollector {
28 public: 29 public:
29 explicit RTCStatsCollector( 30 virtual ~RTCStatsCollectorCallback() {}
31
32 virtual void OnStatsDelivered(
33 const rtc::scoped_refptr<const RTCStatsReport>& report) = 0;
34 };
35
36 // All public methods of the collector are to be called on the signaling thread.
37 // Stats are gathered on the signaling, worker and network threads
38 // asynchronously. The callback is invoked on the signaling thread. Resulting
39 // reports are cached for |cache_lifetime_| ms.
40 class RTCStatsCollector : public virtual rtc::RefCountInterface {
41 public:
42 static rtc::scoped_refptr<RTCStatsCollector> Create(
30 PeerConnection* pc, 43 PeerConnection* pc,
31 int64_t cache_lifetime_us = 50 * rtc::kNumMicrosecsPerMillisec); 44 int64_t cache_lifetime_us = 50 * rtc::kNumMicrosecsPerMillisec);
32 45
33 // Gets a recent stats report. If there is a report cached that is still fresh 46 // Gets a recent stats report. If there is a report cached that is still fresh
34 // it is returned, otherwise new stats are gathered and returned. A report is 47 // it is returned, otherwise new stats are gathered and returned. A report is
35 // considered fresh for |cache_lifetime_| ms. const RTCStatsReports are safe 48 // considered fresh for |cache_lifetime_| ms. const RTCStatsReports are safe
36 // to use across multiple threads and may be destructed on any thread. 49 // to use across multiple threads and may be destructed on any thread.
37 rtc::scoped_refptr<const RTCStatsReport> GetStatsReport(); 50 void GetStatsReport(rtc::scoped_refptr<RTCStatsCollectorCallback> callback);
38 // Clears the cache's reference to the most recent stats report. Subsequently 51 // Clears the cache's reference to the most recent stats report. Subsequently
39 // calling |GetStatsReport| guarantees fresh stats. 52 // calling |GetStatsReport| guarantees fresh stats.
40 void ClearCachedStatsReport(); 53 void ClearCachedStatsReport();
41 54
55 protected:
56 RTCStatsCollector(PeerConnection* pc, int64_t cache_lifetime_us);
57
58 // Stats gathering on a particular thread. Calls |AddPartialResults| before
59 // returning. Virtual for the sake of testing.
60 virtual void ProducePartialResultsOnSignalingThread(int64_t timestamp_us);
61 virtual void ProducePartialResultsOnWorkerThread(int64_t timestamp_us);
62 virtual void ProducePartialResultsOnNetworkThread(int64_t timestamp_us);
63
64 // Can be called on any thread.
65 void AddPartialResults(
66 const rtc::scoped_refptr<RTCStatsReport>& partial_report);
67
42 private: 68 private:
43 bool IsOnSignalingThread() const; 69 void AddPartialResults_s(rtc::scoped_refptr<RTCStatsReport> partial_report);
70 void DeliverCachedReport();
44 71
45 std::unique_ptr<RTCPeerConnectionStats> ProducePeerConnectionStats( 72 std::unique_ptr<RTCPeerConnectionStats> ProducePeerConnectionStats_s(
46 int64_t timestamp_us) const; 73 int64_t timestamp_us) const;
47 74
48 PeerConnection* const pc_; 75 PeerConnection* const pc_;
76 rtc::Thread* const signaling_thread_;
77 rtc::Thread* const worker_thread_;
78 rtc::Thread* const network_thread_;
79 rtc::AsyncInvoker invoker_;
80
81 int num_pending_partial_reports_;
82 int64_t partial_report_timestamp_us_;
83 rtc::scoped_refptr<RTCStatsReport> partial_report_;
84 std::vector<rtc::scoped_refptr<RTCStatsCollectorCallback>> callbacks_;
85
49 // A timestamp, in microseconds, that is based on a timer that is 86 // A timestamp, in microseconds, that is based on a timer that is
50 // monotonically increasing. That is, even if the system clock is modified the 87 // monotonically increasing. That is, even if the system clock is modified the
51 // difference between the timer and this timestamp is how fresh the cached 88 // difference between the timer and this timestamp is how fresh the cached
52 // report is. 89 // report is.
53 int64_t cache_timestamp_us_; 90 int64_t cache_timestamp_us_;
54 int64_t cache_lifetime_us_; 91 int64_t cache_lifetime_us_;
55 rtc::scoped_refptr<const RTCStatsReport> cached_report_; 92 rtc::scoped_refptr<const RTCStatsReport> cached_report_;
56 }; 93 };
57 94
58 } // namespace webrtc 95 } // namespace webrtc
59 96
60 #endif // WEBRTC_STATS_RTCSTATSCOLLECTOR_H_ 97 #endif // WEBRTC_STATS_RTCSTATSCOLLECTOR_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/stats/rtcstatscollector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698