Fix AppRTC Android Demo GN build when is_component_build=true.

Fix AppRTC Android Demo GN build when is_component_build=true.

BUG=webrtc:6174
NOTRY=True

Committed: https://crrev.com/a53fa0a25be5e0fb88d219c02216c013dda35208
Cr-Commit-Position: refs/heads/master@{#13876}

[sakal, 2016-08-23 14:01:20]

Description was changed from

==========
Fix AppRTC Android Demo GN build when is_component_build=true.

BUG=webrtc:6174
==========

to

==========
Fix AppRTC Android Demo GN build when is_component_build=true.

BUG=webrtc:6174
NOTRY=True
==========

[sakal, 2016-08-23 14:01:20]

sakal@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[sakal, 2016-08-23 14:03:23]

PTAL

It seems the system thinks the libjingle_peerconnection_so target only creates
libjingle_peerconnection_so.cr.so without this change. I am not sure if this is
a bug in build system and whether this is the correct way to fix the problem but
it seems to work.

[kjellander_webrtc, 2016-08-23 14:13:59]

kjellander@webrtc.org changed reviewers:
+ dpranke@chromium.org

[kjellander_webrtc, 2016-08-23 14:13:59]

lgtm assuming trybots go green.

dpranke: can you elaborate on the .so stuff?

[Dirk Pranke, 2016-08-23 15:28:32]

On 2016/08/23 14:13:59, kjellander_webrtc wrote:
> lgtm assuming trybots go green.
> 
> dpranke: can you elaborate on the .so stuff?

I didn't actually know about this, but from the comments in the build files:

https://cs.chromium.org/chromium/src/build/toolchain/toolchain.gni?rcl=0&l=70
https://cs.chromium.org/chromium/src/build/common.gypi?rcl=0&l=4773

The common.gypi comment is somewhat more useful: By default on Android, we build
libraries as libskia.cr.so to avoid
a potential conflict with the system library of the same name (libskia.so),
which apparently comes up in a
few places.

[sakal, 2016-08-24 07:24:35]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-08-24 07:24:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-24 07:48:24]

Description was changed from

==========
Fix AppRTC Android Demo GN build when is_component_build=true.

BUG=webrtc:6174
NOTRY=True
==========

to

==========
Fix AppRTC Android Demo GN build when is_component_build=true.

BUG=webrtc:6174
NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-24 07:48:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-24 07:48:35]

Description was changed from

==========
Fix AppRTC Android Demo GN build when is_component_build=true.

BUG=webrtc:6174
NOTRY=True
==========

to

==========
Fix AppRTC Android Demo GN build when is_component_build=true.

BUG=webrtc:6174
NOTRY=True

Committed: https://crrev.com/a53fa0a25be5e0fb88d219c02216c013dda35208
Cr-Commit-Position: refs/heads/master@{#13876}
==========

[commit-bot: I haz the power, 2016-08-24 07:48:36]

Patchset 1 (id:??) landed as
https://crrev.com/a53fa0a25be5e0fb88d219c02216c013dda35208
Cr-Commit-Position: refs/heads/master@{#13876}