Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2269993002: Now probe for x3 and x6 the initial start bitrate. (Closed)

Created:
4 years, 4 months ago by philipel
Modified:
4 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Irfan
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Now probe for x3 and x6 of the initial start bitrate and allow for faster receive bitrates when calculating probing estimates. BUG=webrtc:5859 Committed: https://crrev.com/4e7e8d73004eeb2e8b72fb546888b94fb00dea06 Cr-Commit-Position: refs/heads/master@{#13894}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comment fix. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 4 chunks +9 lines, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_bitrate_estimator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/probe_bitrate_estimator_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
philipel
isheriff@: The |initial_probing_triggered_| can be replaced by the |start_bitrate_bps_| in your CL: https://codereview.webrtc.org/2269873002/ This is ...
4 years, 4 months ago (2016-08-23 13:07:50 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/2269993002/diff/1/webrtc/modules/congestion_controller/congestion_controller.cc File webrtc/modules/congestion_controller/congestion_controller.cc (right): https://codereview.webrtc.org/2269993002/diff/1/webrtc/modules/congestion_controller/congestion_controller.cc#newcode233 webrtc/modules/congestion_controller/congestion_controller.cc:233: if (!initial_probing_triggered_ && start_bitrate_bps > 0) { Can start_bitrate_bps ...
4 years, 4 months ago (2016-08-23 14:54:27 UTC) #4
philipel
https://codereview.webrtc.org/2269993002/diff/1/webrtc/modules/congestion_controller/congestion_controller.cc File webrtc/modules/congestion_controller/congestion_controller.cc (right): https://codereview.webrtc.org/2269993002/diff/1/webrtc/modules/congestion_controller/congestion_controller.cc#newcode233 webrtc/modules/congestion_controller/congestion_controller.cc:233: if (!initial_probing_triggered_ && start_bitrate_bps > 0) { On 2016/08/23 ...
4 years, 4 months ago (2016-08-23 15:49:17 UTC) #5
stefan-webrtc
lgtm
4 years, 4 months ago (2016-08-23 15:49:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2269993002/20001
4 years, 4 months ago (2016-08-23 15:50:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-23 17:51:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2269993002/20001
4 years, 4 months ago (2016-08-24 10:47:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7663)
4 years, 4 months ago (2016-08-24 10:49:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2269993002/40001
4 years, 4 months ago (2016-08-24 10:53:47 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-24 13:27:06 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:27:09 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4e7e8d73004eeb2e8b72fb546888b94fb00dea06
Cr-Commit-Position: refs/heads/master@{#13894}

Powered by Google App Engine
This is Rietveld 408576698