webrtc/modules/rtp_rtcp/source/ulpfec_header_reader_writer.cc - Issue 2269903002: Add FlexFEC header formatters. (pt. 5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/ulpfec_header_reader_writer.cc

Issue 2269903002: Add FlexFEC header formatters. (pt. 5) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@header_reader_writer-pt4-generalize_header_formatting

Patch Set: Review response 5. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/forward_error_correction.cc ('K') | « webrtc/modules/rtp_rtcp/source/ulpfec_header_reader_writer.h ('k') | webrtc/modules/rtp_rtcp/source/ulpfec_header_reader_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/ulpfec_header_reader_writer.cc

diff --git a/webrtc/modules/rtp_rtcp/source/ulpfec_header_reader_writer.cc b/webrtc/modules/rtp_rtcp/source/ulpfec_header_reader_writer.cc

index 2913482554c4b58c095de97129d1a57d9cc06e2e..904ca8a59b532bf9e8eb2e916102fe45e22ecc0a 100644

--- a/webrtc/modules/rtp_rtcp/source/ulpfec_header_reader_writer.cc

+++ b/webrtc/modules/rtp_rtcp/source/ulpfec_header_reader_writer.cc

@@ -99,6 +99,7 @@ size_t UlpfecHeaderWriter::FecHeaderSize(size_t packet_mask_size) const {

}

void UlpfecHeaderWriter::FinalizeFecHeader(

+ uint32_t media_ssrc,

danilchap 2016/09/21 11:17:56 there is construct uint32_t /* media_ssrc */ to st

brandtr 2016/09/21 11:43:28 Done.

uint16_t seq_num_base,

const uint8_t* packet_mask,

size_t packet_mask_size,