Issue 2268973003: GN: Add libjingle_peerconnection_java to peerconnection_unittests.

Issue 2268973003: GN: Add libjingle_peerconnection_java to peerconnection_unittests. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc

Modified:
4 years, 3 months ago

Reviewers:
ehmaldonado_webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

GN: Add libjingle_peerconnection_java to peerconnection_unittests. This dependency was found missing since it's defined in https://cs.chromium.org/chromium/src/third_party/webrtc/build/android_tests.gyp?rcl=0&l=129 which causes many of the tests to crash with org.webrtc.AudioTrack class not being found. BUG=webrtc:5949 TBR=ehmaldonado@webrtc.org NOTRY=True TESTED=Passing local run of peerconnection_unittests on Android. Committed: https://crrev.com/b37c45cadc9786c5c77205247dbbdad4da6b10b4 Cr-Commit-Position: refs/heads/master@{#13867}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webrtc/api/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 8 (4 generated)

kjellander_webrtc

As discussed offline, this fixes the last failing Android test for GN.

4 years, 3 months ago (2016-08-23 19:35:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2268973003/1

4 years, 3 months ago (2016-08-23 19:45:06 UTC) #4

commit-bot: I haz the power

4 years, 3 months ago (2016-08-23 19:55:54 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b37c45cadc9786c5c77205247dbbdad4da6b10b4
Cr-Commit-Position: refs/heads/master@{#13867}