Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2268343002:
Add missing dependencies to setup_links. (Closed)
|
Created:
4 years, 4 months ago by ehmaldonado_webrtc Modified:
4 years, 4 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd missing dependencies to setup_links.
Fixes the following error for Android GN bots when trying
to roll Chromium into WebRTC.
Full logs at:
https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/13405/steps/generate_build_files/logs/stdio
/b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check
-> returned 1
ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file.
deps += [ "${_target_label}__build_config" ]
^-------------------------------
Unable to load:
/b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn
I also checked in the secondary tree for:
/b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn
GN gen failed: 1
BUG=522043
NOTRY=True
Committed: https://crrev.com/cd8ae61b279809a3e0e9da926f9bb204f49c1c8a
Cr-Commit-Position: refs/heads/master@{#13886}
Patch Set 1 #Patch Set 2 : Updated .gitignore. #
Messages
Total messages: 20 (10 generated)
ehmaldonado@webrtc.org changed reviewers: + kjellander@webrtc.org
Description was changed from
==========
Add missing dependencies to setup_links.
Fixes the following error when trying to roll Chromium into WebRTC.
/b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check
-> returned 1
ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input
file.
deps += [ "${_target_label}__build_config" ]
^-------------------------------
Unable to load:
/b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn
I also checked in the secondary tree for:
/b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn
GN gen failed: 1
BUG=
==========
to
==========
Add missing dependencies to setup_links.
Fixes the following error for Android GN bots when trying
to roll Chromium into WebRTC.
Full logs at:
https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/...
/b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check
-> returned 1
ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input
file.
deps += [ "${_target_label}__build_config" ]
^-------------------------------
Unable to load:
/b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn
I also checked in the secondary tree for:
/b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn
GN gen failed: 1
BUG=
==========
Description was changed from ========== Add missing dependencies to setup_links. Fixes the following error for Android GN bots when trying to roll Chromium into WebRTC. Full logs at: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/... /b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file. deps += [ "${_target_label}__build_config" ] ^------------------------------- Unable to load: /b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn I also checked in the secondary tree for: /b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn GN gen failed: 1 BUG= ========== to ========== Add missing dependencies to setup_links. Fixes the following error for Android GN bots when trying to roll Chromium into WebRTC. Full logs at: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/... /b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file. deps += [ "${_target_label}__build_config" ] ^------------------------------- Unable to load: /b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn I also checked in the secondary tree for: /b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn GN gen failed: 1 BUG=522043 ==========
There was an issue like this one before: https://codereview.webrtc.org/2190893002/
Nice detective work! lgtm if you add the same dirs to .gitignore.
The CQ bit was checked by ehmaldonado@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/2268343002/#ps20001 (title: "Updated .gitignore.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
On 2016/08/24 07:53:57, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/... Argh, should have used NOTRY=True here...
On 2016/08/24 09:30:12, kjellander_webrtc wrote: > On 2016/08/24 07:53:57, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/... > > Argh, should have used NOTRY=True here... Yeah, sorry :(
On 2016/08/24 09:32:44, ehmaldonado_webrtc wrote: > On 2016/08/24 09:30:12, kjellander_webrtc wrote: > > On 2016/08/24 07:53:57, commit-bot: I haz the power wrote: > > > CQ is trying da patch. Follow status at > > > > > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/... > > > > Argh, should have used NOTRY=True here... > > Yeah, sorry :( You can always do it now though, to unblock your rolling test.
Description was changed from ========== Add missing dependencies to setup_links. Fixes the following error for Android GN bots when trying to roll Chromium into WebRTC. Full logs at: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/... /b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file. deps += [ "${_target_label}__build_config" ] ^------------------------------- Unable to load: /b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn I also checked in the secondary tree for: /b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn GN gen failed: 1 BUG=522043 ========== to ========== Add missing dependencies to setup_links. Fixes the following error for Android GN bots when trying to roll Chromium into WebRTC. Full logs at: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/... /b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file. deps += [ "${_target_label}__build_config" ] ^------------------------------- Unable to load: /b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn I also checked in the secondary tree for: /b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn GN gen failed: 1 BUG=522043 NOTRY=True ==========
The CQ bit was unchecked by ehmaldonado@webrtc.org
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Add missing dependencies to setup_links. Fixes the following error for Android GN bots when trying to roll Chromium into WebRTC. Full logs at: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/... /b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file. deps += [ "${_target_label}__build_config" ] ^------------------------------- Unable to load: /b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn I also checked in the secondary tree for: /b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn GN gen failed: 1 BUG=522043 NOTRY=True ========== to ========== Add missing dependencies to setup_links. Fixes the following error for Android GN bots when trying to roll Chromium into WebRTC. Full logs at: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/... /b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file. deps += [ "${_target_label}__build_config" ] ^------------------------------- Unable to load: /b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn I also checked in the secondary tree for: /b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn GN gen failed: 1 BUG=522043 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add missing dependencies to setup_links. Fixes the following error for Android GN bots when trying to roll Chromium into WebRTC. Full logs at: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/... /b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file. deps += [ "${_target_label}__build_config" ] ^------------------------------- Unable to load: /b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn I also checked in the secondary tree for: /b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn GN gen failed: 1 BUG=522043 NOTRY=True ========== to ========== Add missing dependencies to setup_links. Fixes the following error for Android GN bots when trying to roll Chromium into WebRTC. Full logs at: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/... /b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file. deps += [ "${_target_label}__build_config" ] ^------------------------------- Unable to load: /b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn I also checked in the secondary tree for: /b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn GN gen failed: 1 BUG=522043 NOTRY=True Committed: https://crrev.com/cd8ae61b279809a3e0e9da926f9bb204f49c1c8a Cr-Commit-Position: refs/heads/master@{#13886} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cd8ae61b279809a3e0e9da926f9bb204f49c1c8a Cr-Commit-Position: refs/heads/master@{#13886} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
