Added GN target for webrtc_opus_fec_test.

Added GN target for webrtc_opus_fec_test.

BUG=webrtc:6191
NOTRY=True
NOPRESUBMIT=True

Committed: https://crrev.com/2c670dbf13cd631534770d43ec5a9259aeaba6a9
Cr-Commit-Position: refs/heads/master@{#13893}

[ivoc, 2016-08-23 08:29:19]

Description was changed from

==========
Added GN target for webrtc_opus_fec_test.

BUG=webrtc:6191
==========

to

==========
Added GN target for webrtc_opus_fec_test.

BUG=webrtc:6191
==========

[ivoc, 2016-08-23 08:29:20]

ivoc@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ivoc, 2016-08-23 08:31:25]

Hi Henrik, PTAL.

[kjellander_webrtc, 2016-08-23 08:54:45]

https://codereview.webrtc.org/2268213002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2268213002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1554: "//testing/gtest",
Please add
"//build/config/sanitizers:deps",
to deps. It's likely needed in order to build for the sanitizers.

[ivoc, 2016-08-23 10:34:36]

PTAL.

https://codereview.webrtc.org/2268213002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2268213002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1554: "//testing/gtest",
On 2016/08/23 08:54:45, kjellander_webrtc wrote:
> Please add
> "//build/config/sanitizers:deps",
> to deps. It's likely needed in order to build for the sanitizers.

Done.

[kjellander_webrtc, 2016-08-23 11:36:57]

https://codereview.webrtc.org/2268213002/diff/60001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2268213002/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:1552: "../../base:rtc_base",
Is rtc_base really needed? I would hope for rtc_base_approved is enough?

Plz update the GYP target as well.

[ivoc, 2016-08-24 10:54:32]

Description was changed from

==========
Added GN target for webrtc_opus_fec_test.

BUG=webrtc:6191
==========

to

==========
Added GN target for webrtc_opus_fec_test.

BUG=webrtc:6191
NOTRY=True
NOPRESUBMIT=True
==========

[ivoc, 2016-08-24 10:56:56]

https://codereview.webrtc.org/2268213002/diff/60001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2268213002/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:1552: "../../base:rtc_base",
On 2016/08/23 11:36:57, kjellander_webrtc wrote:
> Is rtc_base really needed? I would hope for rtc_base_approved is enough?
> 
> Plz update the GYP target as well.

This is the same issue as in my other CL, webrtc/base/format_macros.h is used
here, which is only in rtc_base, not in rtc_base_approved.

Added to gyp as well.

[kjellander_webrtc, 2016-08-24 11:29:30]

lgtm

https://codereview.webrtc.org/2268213002/diff/60001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2268213002/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:1552: "../../base:rtc_base",
On 2016/08/24 10:56:56, ivoc wrote:
> On 2016/08/23 11:36:57, kjellander_webrtc wrote:
> > Is rtc_base really needed? I would hope for rtc_base_approved is enough?
> > 
> > Plz update the GYP target as well.
> 
> This is the same issue as in my other CL, webrtc/base/format_macros.h is used
> here, which is only in rtc_base, not in rtc_base_approved.
> 
> Added to gyp as well.

OK. webrtc/base/format_macros.h doesn't depend on anything else in webrtc_base
so it would actually be suitable to move to rtc_base_approved. Feel free to do
that in a separate CL (or at least post it as a suggestion in
https://bugs.chromium.org/p/webrtc/issues/detail?id=3806)

[ivoc, 2016-08-24 13:11:06]

The CQ bit was checked by ivoc@webrtc.org

[commit-bot: I haz the power, 2016-08-24 13:11:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-24 13:11:20]

Description was changed from

==========
Added GN target for webrtc_opus_fec_test.

BUG=webrtc:6191
NOTRY=True
NOPRESUBMIT=True
==========

to

==========
Added GN target for webrtc_opus_fec_test.

BUG=webrtc:6191
NOTRY=True
NOPRESUBMIT=True
==========

[commit-bot: I haz the power, 2016-08-24 13:11:22]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-24 13:11:30]

Description was changed from

==========
Added GN target for webrtc_opus_fec_test.

BUG=webrtc:6191
NOTRY=True
NOPRESUBMIT=True
==========

to

==========
Added GN target for webrtc_opus_fec_test.

BUG=webrtc:6191
NOTRY=True
NOPRESUBMIT=True

Committed: https://crrev.com/2c670dbf13cd631534770d43ec5a9259aeaba6a9
Cr-Commit-Position: refs/heads/master@{#13893}
==========

[commit-bot: I haz the power, 2016-08-24 13:11:31]

Patchset 6 (id:??) landed as
https://crrev.com/2c670dbf13cd631534770d43ec5a9259aeaba6a9
Cr-Commit-Position: refs/heads/master@{#13893}