Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: webrtc/tools/BUILD.gn

Issue 2268183007: Don't use VoE legacy APIs in force_mic_volume_max tool. (Closed)
Patch Set: Exclude force_mic_volume_max target when rtc_include_internal_audio_device not set. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/tools/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/BUILD.gn
diff --git a/webrtc/tools/BUILD.gn b/webrtc/tools/BUILD.gn
index 04c4543b0af0f712fda7c730f611a4f607cc4328..e80d02b53c1d0efb0eed201394590619d751b81d 100644
--- a/webrtc/tools/BUILD.gn
+++ b/webrtc/tools/BUILD.gn
@@ -117,22 +117,25 @@ rtc_executable("frame_editor") {
]
}
-rtc_executable("force_mic_volume_max") {
- sources = [
- "force_mic_volume_max/force_mic_volume_max.cc",
- ]
+# It doesn't make sense to build this tool without the ADM enabled.
+if (rtc_include_internal_audio_device) {
+ rtc_executable("force_mic_volume_max") {
+ sources = [
+ "force_mic_volume_max/force_mic_volume_max.cc",
+ ]
- if (is_clang) {
- # Suppress warnings from the Chromium Clang plugin.
- # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
- suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
- }
+ if (is_clang) {
+ # Suppress warnings from the Chromium Clang plugin.
+ # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
- deps = [
- "../system_wrappers:system_wrappers_default",
- "../voice_engine",
- "//build/win:default_exe_manifest",
- ]
+ deps = [
+ "../modules/audio_device:audio_device",
+ "../system_wrappers:system_wrappers_default",
+ "//build/win:default_exe_manifest",
+ ]
+ }
}
if (rtc_enable_protobuf) {
« no previous file with comments | « no previous file | webrtc/tools/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698