Fix error when accumulating floats in an int.

Fix error when accumulating floats in an int.

I saw this when browsing the code, I think the intended behavior is accumulating to a float.

BUG=none

Committed: https://crrev.com/3f746ea26a74311651ae91d44b75e37ab17a7481
Cr-Commit-Position: refs/heads/master@{#13918}

[Max Morin WebRTC, 2016-08-24 14:42:19]

Description was changed from

==========
Fix error when accumulating floats in an int.

BUG=none
==========

to

==========
Fix error when accumulating floats in an int.

I saw this when browsing the code, I think the intended behavior is accumulating
to a float.

BUG=none
==========

[Max Morin WebRTC, 2016-08-24 14:42:19]

maxmorin@webrtc.org changed reviewers:
+ peah@webrtc.org

[Max Morin WebRTC, 2016-08-24 14:44:02]

Peah: PTAL at this 2-byte patch. I added you as a reviewer since you are the
original author.

[the sun, 2016-08-24 19:41:32]

solenberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-08-24 19:41:32]

https://codereview.webrtc.org/2268163004/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/level_controller/level_controller.cc
(right):

https://codereview.webrtc.org/2268163004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/level_controller/level_controller.cc:38:
std::accumulate(x.begin(), x.end(), 0.0) / static_cast<float>(x.size());
Nice catch! Make it a 0.0f so we're not using doubles too.

[peah-webrtc, 2016-08-25 07:49:51]

On 2016/08/24 19:41:32, the sun wrote:
>
https://codereview.webrtc.org/2268163004/diff/1/webrtc/modules/audio_processi...
> File webrtc/modules/audio_processing/level_controller/level_controller.cc
> (right):
> 
>
https://codereview.webrtc.org/2268163004/diff/1/webrtc/modules/audio_processi...
> webrtc/modules/audio_processing/level_controller/level_controller.cc:38:
> std::accumulate(x.begin(), x.end(), 0.0) / static_cast<float>(x.size());
> Nice catch! Make it a 0.0f so we're not using doubles too.

Awesome catch!!! This definitely makes a difference, but the former
implementation (the summing into ints) was not a catastrophe thanks to the fact
that the range of the float samples is -32768.0f to 32767.0f. Therefore this
should fortunately not have led to any huge issues so far.


lgtm conditioned that you make the change to sum floats instead of doubles
proposed by solenberg@.

[the sun, 2016-08-25 09:41:12]

solenberg@webrtc.org changed reviewers:
- solenberg@webrtc.org

[Max Morin WebRTC, 2016-08-25 09:58:45]

The CQ bit was checked by maxmorin@webrtc.org

[Max Morin WebRTC, 2016-08-25 09:58:46]

The patchset sent to the CQ was uploaded after l-g-t-m from peah@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2268163004/#ps20001 (title:
"Actually fix the problem.")

[commit-bot: I haz the power, 2016-08-25 09:58:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-25 11:00:23]

Description was changed from

==========
Fix error when accumulating floats in an int.

I saw this when browsing the code, I think the intended behavior is accumulating
to a float.

BUG=none
==========

to

==========
Fix error when accumulating floats in an int.

I saw this when browsing the code, I think the intended behavior is accumulating
to a float.

BUG=none
==========

[commit-bot: I haz the power, 2016-08-25 11:00:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 11:00:29]

Description was changed from

==========
Fix error when accumulating floats in an int.

I saw this when browsing the code, I think the intended behavior is accumulating
to a float.

BUG=none
==========

to

==========
Fix error when accumulating floats in an int.

I saw this when browsing the code, I think the intended behavior is accumulating
to a float.

BUG=none

Committed: https://crrev.com/3f746ea26a74311651ae91d44b75e37ab17a7481
Cr-Commit-Position: refs/heads/master@{#13918}
==========

[commit-bot: I haz the power, 2016-08-25 11:00:30]

Patchset 2 (id:??) landed as
https://crrev.com/3f746ea26a74311651ae91d44b75e37ab17a7481
Cr-Commit-Position: refs/heads/master@{#13918}