Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2268063002: Define a protobuf format for representing plots (Closed)

Created:
4 years, 4 months ago by terelius
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Define a protobuf format for representing plots. Add code to convert the C-representation generated by the RtcEventLog analysis tool, to the new protobuf format. BUG=webrtc:6249 NOTRY=True Committed: https://crrev.com/b246a292cd3dad8f6d4fb8521bcd115c794c15c9 Cr-Commit-Position: refs/heads/master@{#13873}

Patch Set 1 #

Patch Set 2 : Add GN build rule. #

Patch Set 3 : Add plot_protobuf.* to source list for visualization tool. #

Total comments: 2

Patch Set 4 : Nit #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -12 lines) Patch
M webrtc/tools/BUILD.gn View 1 2 3 4 3 chunks +11 lines, -0 lines 0 comments Download
A webrtc/tools/event_log_visualizer/graph.proto View 1 chunk +32 lines, -0 lines 0 comments Download
A + webrtc/tools/event_log_visualizer/plot_protobuf.h View 1 chunk +12 lines, -9 lines 0 comments Download
A webrtc/tools/event_log_visualizer/plot_protobuf.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M webrtc/tools/tools.gyp View 1 2 3 4 2 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
terelius
Vlad, could you review event_log_visualizer/* Henrik, could you review the gyp and gn changes?
4 years, 4 months ago (2016-08-23 03:22:15 UTC) #4
kjellander_webrtc
lgtm with nit. Please add a BUG= entry to the CL description. https://codereview.webrtc.org/2268063002/diff/40001/webrtc/tools/BUILD.gn File webrtc/tools/BUILD.gn ...
4 years, 4 months ago (2016-08-23 06:02:20 UTC) #5
skvlad
lgtm
4 years, 4 months ago (2016-08-23 08:31:06 UTC) #6
terelius
https://codereview.webrtc.org/2268063002/diff/40001/webrtc/tools/BUILD.gn File webrtc/tools/BUILD.gn (right): https://codereview.webrtc.org/2268063002/diff/40001/webrtc/tools/BUILD.gn#newcode11 webrtc/tools/BUILD.gn:11: import("//third_party/protobuf/proto_library.gni") On 2016/08/23 06:02:20, kjellander_webrtc wrote: > nit: sort ...
4 years, 4 months ago (2016-08-23 17:54:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2268063002/60001
4 years, 4 months ago (2016-08-23 21:06:07 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/13583)
4 years, 4 months ago (2016-08-23 21:09:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2268063002/80001
4 years, 4 months ago (2016-08-24 01:05:28 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-24 01:15:31 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 01:15:41 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b246a292cd3dad8f6d4fb8521bcd115c794c15c9
Cr-Commit-Position: refs/heads/master@{#13873}

Powered by Google App Engine
This is Rietveld 408576698