Add logs and small change in BasicPortAllocator

Add logs and small change in BasicPortAllocator.

The added logs will be helpful for debugging.
If a session has stopped, terminate DoAllocate early.
Session::init always returns true, so there is no need to check the return value.

R=deadbeef@webrtc.org, skvlad@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/5048f5777dda576f321c8ab08888291549ea72f4

[honghaiz3, 2016-08-22 22:56:19]

Description was changed from

==========
Add logs and small change in BasicPortAllocator
==========

to

==========
Add logs and small change in BasicPortAllocator. 

If a session has stopped, terminate the DoAllocate early. 
Session::init always returns true, so there is no need to check the return
value.
==========

[honghaiz3, 2016-08-22 22:56:33]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-08-22 23:03:11]

Description was changed from

==========
Add logs and small change in BasicPortAllocator. 

If a session has stopped, terminate the DoAllocate early. 
Session::init always returns true, so there is no need to check the return
value.
==========

to

==========
Add logs and small change in BasicPortAllocator. 

The added logs will be helpful for debugging. 
If a session has stopped, terminate DoAllocate early. 
Session::init always returns true, so there is no need to check the return
value.
==========

[skvlad, 2016-08-22 23:17:34]

skvlad@webrtc.org changed reviewers:
+ skvlad@webrtc.org

[skvlad, 2016-08-22 23:17:35]

lgtm for the change - assuming I understand the behavior of the class correctly.

[honghaiz3, 2016-08-23 21:29:43]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-08-23 21:29:43]

The patchset sent to the CQ was uploaded after l-g-t-m from skvlad@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2267163002/#ps40001 (title:
"Log allocating ports only if the network list is not empty.")

[commit-bot: I haz the power, 2016-08-23 21:29:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Taylor Brandstetter, 2016-08-23 21:50:08]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2016-08-23 21:50:09]

lgtm

https://codereview.webrtc.org/2267163002/diff/40001/webrtc/p2p/client/basicpo...
File webrtc/p2p/client/basicportallocator.cc (right):

https://codereview.webrtc.org/2267163002/diff/40001/webrtc/p2p/client/basicpo...
webrtc/p2p/client/basicportallocator.cc:552: if (IsStopped()) {
Is this condition only hit when regathering due to a network change?

[honghaiz3, 2016-08-23 22:06:25]

https://codereview.webrtc.org/2267163002/diff/40001/webrtc/p2p/client/basicpo...
File webrtc/p2p/client/basicportallocator.cc (right):

https://codereview.webrtc.org/2267163002/diff/40001/webrtc/p2p/client/basicpo...
webrtc/p2p/client/basicportallocator.cc:552: if (IsStopped()) {
On 2016/08/23 21:50:09, Taylor Brandstetter wrote:
> Is this condition only hit when regathering due to a network change?

yes.

[commit-bot: I haz the power, 2016-08-23 22:47:52]

Description was changed from

==========
Add logs and small change in BasicPortAllocator. 

The added logs will be helpful for debugging. 
If a session has stopped, terminate DoAllocate early. 
Session::init always returns true, so there is no need to check the return
value.
==========

to

==========
Add logs and small change in BasicPortAllocator.

The added logs will be helpful for debugging.
If a session has stopped, terminate DoAllocate early.
Session::init always returns true, so there is no need to check the return
value.

R=deadbeef@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/5048f5777dda576f321c8ab08888291549ea72f4
Cr-Commit-Position: refs/heads/master@{#13871}
==========

[commit-bot: I haz the power, 2016-08-23 22:47:53]

Patchset 2 (id:??) landed as
https://crrev.com/5048f5777dda576f321c8ab08888291549ea72f4
Cr-Commit-Position: refs/heads/master@{#13871}

[honghaiz3, 2016-08-23 22:48:08]

Description was changed from

==========
Add logs and small change in BasicPortAllocator.

The added logs will be helpful for debugging.
If a session has stopped, terminate DoAllocate early.
Session::init always returns true, so there is no need to check the return
value.

R=deadbeef@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/5048f5777dda576f321c8ab08888291549ea72f4
Cr-Commit-Position: refs/heads/master@{#13871}
==========

to

==========
Add logs and small change in BasicPortAllocator.

The added logs will be helpful for debugging.
If a session has stopped, terminate DoAllocate early.
Session::init always returns true, so there is no need to check the return
value.

R=deadbeef@webrtc.org, skvlad@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/5048f5777dda576f321c8ab08...
==========

[honghaiz3, 2016-08-23 22:48:09]

Committed patchset #2 (id:40001) manually as
5048f5777dda576f321c8ab08888291549ea72f4 (presubmit successful).