Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2267113002: GN: Fix test_support_unittests and MIPS compile issue. (Closed)

Created:
4 years, 4 months ago by kjellander_webrtc
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix test_support_unittests and MIPS compile issue. Move the webrtc/test/test_support/metrics sources into test_support[_unittests] targets. This is essentially reverting https://webrtc-codereview.appspot.com/5789004 and moving these sources back to the right target. Add missing foreman_cif.yuv resource needed for these tests. For MIPS, a compile error was surfacing for logcat_trace_context.h when flipping bot to GN, which was fixed. BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/d8dd190a085ff02b83be600da7a0b2e844eb9ffe Cr-Commit-Position: refs/heads/master@{#13860}

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Move all metrics/ sources and remove metrics.gyp #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -41 lines) Patch
M all.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/tools/video_codecs_tools.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/include/logcat_trace_context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D webrtc/test/metrics.gyp View 1 2 1 chunk +0 lines, -32 lines 1 comment Download
M webrtc/test/test.gyp View 1 2 4 chunks +5 lines, -0 lines 0 comments Download
M webrtc/test/test_support_unittests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 2 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
kjellander_webrtc
4 years, 4 months ago (2016-08-22 21:13:35 UTC) #4
kjellander_webrtc
I'm confident NOTRY=True is safe here, I successfully ran test_support_unittests on my local Android device. ...
4 years, 4 months ago (2016-08-23 06:29:54 UTC) #10
kjellander_webrtc
+henrika to rubberstamp webrtc/system_wrappers/include/logcat_trace_context.h
4 years, 4 months ago (2016-08-23 06:30:45 UTC) #12
ehmaldonado_webrtc
On 2016/08/23 06:30:45, kjellander_webrtc wrote: > +henrika to rubberstamp webrtc/system_wrappers/include/logcat_trace_context.h lgtm
4 years, 4 months ago (2016-08-23 07:38:28 UTC) #13
henrika_webrtc
LGTM
4 years, 4 months ago (2016-08-23 11:37:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2267113002/40001
4 years, 4 months ago (2016-08-23 11:44:35 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-23 11:52:15 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 11:52:24 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d8dd190a085ff02b83be600da7a0b2e844eb9ffe
Cr-Commit-Position: refs/heads/master@{#13860}

Powered by Google App Engine
This is Rietveld 408576698