Fuzzer for FEC header readers. (pt. 6a)

Fuzzer for FEC header readers.

BUG=webrtc:5654
Committed: https://crrev.com/cada34cd9823630c0ee6285366b726e03184a952
Cr-Commit-Position: refs/heads/master@{#14470}

[brandtr, 2016-08-22 10:45:37]

brandtr@webrtc.org changed reviewers:
+ stefan@webrtc.org

[brandtr, 2016-08-22 10:45:37]

A simple (possibly suboptimal) fuzzer for the FEC header reading code.

Ran it over the weekend on my workstation and a ubiquity instance, without
crashing.

[brandtr, 2016-08-24 11:45:15]

Rebase.

[brandtr, 2016-08-25 13:27:20]

Rebase.

[brandtr, 2016-08-26 11:23:01]

Rebase

[brandtr, 2016-08-30 07:13:11]

Rebase.

[brandtr, 2016-08-30 14:31:36]

Description was changed from

==========
Fuzzer for FEC header readers.

BUG=webrtc:5654
==========

to

==========
Fuzzer for FEC header readers.

BUG=webrtc:5654
==========

[brandtr, 2016-08-30 14:34:10]

Description was changed from

==========
Fuzzer for FEC header readers.

BUG=webrtc:5654
==========

to

==========
Fuzzer for FEC header formatters.

BUG=webrtc:5654
==========

[brandtr, 2016-08-30 14:34:26]

Description was changed from

==========
Fuzzer for FEC header formatters.

BUG=webrtc:5654
==========

to

==========
Fuzzer for FEC header readers.

BUG=webrtc:5654
==========

[brandtr, 2016-09-02 09:40:34]

Rebase.

[brandtr, 2016-09-06 14:36:20]

Rebase.

[brandtr, 2016-09-12 10:30:43]

Cleaned up a bit.

[stefan-webrtc, 2016-09-13 10:42:21]

lgtm

https://codereview.webrtc.org/2265493002/diff/140001/webrtc/test/fuzzers/ulpf...
File webrtc/test/fuzzers/ulpfec_header_reader_fuzzer.cc (right):

https://codereview.webrtc.org/2265493002/diff/140001/webrtc/test/fuzzers/ulpf...
webrtc/test/fuzzers/ulpfec_header_reader_fuzzer.cc:21: if (size >
IP_PACKET_SIZE) {
Instead of doing this you can just copy at most IP_PACKET_SIZE at line 27.

[stefan-webrtc, 2016-09-13 10:42:31]

On 2016/09/13 10:42:21, stefan-webrtc (holmer) wrote:
> lgtm
> 
>
https://codereview.webrtc.org/2265493002/diff/140001/webrtc/test/fuzzers/ulpf...
> File webrtc/test/fuzzers/ulpfec_header_reader_fuzzer.cc (right):
> 
>
https://codereview.webrtc.org/2265493002/diff/140001/webrtc/test/fuzzers/ulpf...
> webrtc/test/fuzzers/ulpfec_header_reader_fuzzer.cc:21: if (size >
> IP_PACKET_SIZE) {
> Instead of doing this you can just copy at most IP_PACKET_SIZE at line 27.

% this comment...

[brandtr, 2016-09-13 10:53:47]

Patchset #9 (id:160001) has been deleted

[brandtr, 2016-09-13 10:59:28]

https://codereview.webrtc.org/2265493002/diff/140001/webrtc/test/fuzzers/ulpf...
File webrtc/test/fuzzers/ulpfec_header_reader_fuzzer.cc (right):

https://codereview.webrtc.org/2265493002/diff/140001/webrtc/test/fuzzers/ulpf...
webrtc/test/fuzzers/ulpfec_header_reader_fuzzer.cc:21: if (size >
IP_PACKET_SIZE) {
On 2016/09/13 10:42:21, stefan-webrtc (holmer) wrote:
> Instead of doing this you can just copy at most IP_PACKET_SIZE at line 27.

Done.

[brandtr, 2016-09-14 11:43:42]

Rebase.

[brandtr, 2016-09-21 10:50:44]

Rebase.

[brandtr, 2016-09-27 08:20:20]

Rebase.

[brandtr, 2016-09-30 11:24:14]

Rebase

[brandtr, 2016-10-03 07:59:13]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-10-03 07:59:13]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2265493002/#ps260001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-10-03 07:59:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2016-10-03 08:32:59]

The CQ bit was unchecked by brandtr@webrtc.org

[brandtr, 2016-10-03 08:37:27]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-10-03 08:37:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2016-10-03 08:49:31]

The CQ bit was unchecked by brandtr@webrtc.org

[brandtr, 2016-10-03 08:55:38]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-10-03 08:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-03 09:02:51]

Description was changed from

==========
Fuzzer for FEC header readers.

BUG=webrtc:5654
==========

to

==========
Fuzzer for FEC header readers.

BUG=webrtc:5654
==========

[commit-bot: I haz the power, 2016-10-03 09:02:52]

Committed patchset #13 (id:260001)

[commit-bot: I haz the power, 2016-10-03 09:02:58]

Description was changed from

==========
Fuzzer for FEC header readers.

BUG=webrtc:5654
==========

to

==========
Fuzzer for FEC header readers.

BUG=webrtc:5654

Committed: https://crrev.com/cada34cd9823630c0ee6285366b726e03184a952
Cr-Commit-Position: refs/heads/master@{#14470}
==========

[commit-bot: I haz the power, 2016-10-03 09:02:59]

Patchset 13 (id:??) landed as
https://crrev.com/cada34cd9823630c0ee6285366b726e03184a952
Cr-Commit-Position: refs/heads/master@{#14470}