webrtc/modules/bitrate_controller/include/bitrate_controller.h - Issue 2263973004: Set send side bitrate estimate on successful probing attempt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/include/bitrate_controller.h

Issue 2263973004: Set send side bitrate estimate on successful probing attempt. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/bitrate_controller_impl.cc ('k') | webrtc/modules/congestion_controller/delay_based_bwe.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/include/bitrate_controller.h

diff --git a/webrtc/modules/bitrate_controller/include/bitrate_controller.h b/webrtc/modules/bitrate_controller/include/bitrate_controller.h

index f06314cd4ab5cc071abff48acf79b4dfddb90577..ac76b93c1f1bfd9a775f616aa5a3868593f3029a 100644

--- a/webrtc/modules/bitrate_controller/include/bitrate_controller.h

+++ b/webrtc/modules/bitrate_controller/include/bitrate_controller.h

@@ -79,6 +79,8 @@ class BitrateController : public Module {

virtual void UpdateDelayBasedEstimate(uint32_t bitrate_bps) = 0;

+ virtual void UpdateProbeBitrate(uint32_t bitrate_bps) {}

stefan-webrtc 2016/08/23 09:58:27 Do you need a default impl?

philipel 2016/08/23 16:05:35 Yes, otherwise it will fail when linking.

stefan-webrtc 2016/08/23 16:17:29 Make it pure virtual

// Gets the available payload bandwidth in bits per second. Note that

// this bandwidth excludes packet headers.

virtual bool AvailableBandwidth(uint32_t* bandwidth) const = 0;