Set send side bitrate estimate on successful probing attempt.

Set send side bitrate estimate on successful probing attempt.

BUG=webrtc:5859
Committed: https://crrev.com/0aa9d1808b81cc949a66d0fb6adbd1c0e1d74eb3
Cr-Commit-Position: refs/heads/master@{#13887}

[philipel, 2016-08-22 13:28:05]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-08-23 09:58:27]

Is it possible to add a test on CongestionController level (or EndToEndTests
level) which verifies that a received probe actually makes it all the way to the
final bandwidth estimate?

https://codereview.webrtc.org/2263973004/diff/1/webrtc/modules/bitrate_contro...
File webrtc/modules/bitrate_controller/include/bitrate_controller.h (right):

https://codereview.webrtc.org/2263973004/diff/1/webrtc/modules/bitrate_contro...
webrtc/modules/bitrate_controller/include/bitrate_controller.h:82: virtual void
UpdateProbeBitrate(uint32_t bitrate_bps) {}
Do you need a default impl?

[philipel, 2016-08-23 16:05:35]

Looks like it requires some work to set up a test for that, but I have tested it
locally with hangouts and it has worked well.

https://codereview.webrtc.org/2263973004/diff/1/webrtc/modules/bitrate_contro...
File webrtc/modules/bitrate_controller/include/bitrate_controller.h (right):

https://codereview.webrtc.org/2263973004/diff/1/webrtc/modules/bitrate_contro...
webrtc/modules/bitrate_controller/include/bitrate_controller.h:82: virtual void
UpdateProbeBitrate(uint32_t bitrate_bps) {}
On 2016/08/23 09:58:27, stefan-webrtc (holmer) wrote:
> Do you need a default impl?

Yes, otherwise it will fail when linking.

[stefan-webrtc, 2016-08-23 16:17:29]

https://codereview.webrtc.org/2263973004/diff/1/webrtc/modules/bitrate_contro...
File webrtc/modules/bitrate_controller/include/bitrate_controller.h (right):

https://codereview.webrtc.org/2263973004/diff/1/webrtc/modules/bitrate_contro...
webrtc/modules/bitrate_controller/include/bitrate_controller.h:82: virtual void
UpdateProbeBitrate(uint32_t bitrate_bps) {}
On 2016/08/23 16:05:35, philipel wrote:
> On 2016/08/23 09:58:27, stefan-webrtc (holmer) wrote:
> > Do you need a default impl?
> 
> Yes, otherwise it will fail when linking.

Make it pure virtual

[stefan-webrtc, 2016-08-23 16:23:10]

lgtm

[philipel, 2016-08-23 16:23:40]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2016-08-23 16:23:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-23 18:24:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 18:24:34]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[philipel, 2016-08-24 08:18:28]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2016-08-24 08:18:29]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2263973004/#ps40001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-08-24 08:18:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-24 08:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 08:20:22]

Try jobs failed on following builders:
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_rel/builds/2118)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/12052)
  mac_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/5527)

[philipel, 2016-08-24 08:39:06]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2016-08-24 08:39:07]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2263973004/#ps60001 (title:
"Rebase Fix")

[commit-bot: I haz the power, 2016-08-24 08:39:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-24 09:45:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-24 09:45:48]

Description was changed from

==========
Set send side bitrate estimate on successful probing attempt.

BUG=webrtc:5859
==========

to

==========
Set send side bitrate estimate on successful probing attempt.

BUG=webrtc:5859

Committed: https://crrev.com/0aa9d1808b81cc949a66d0fb6adbd1c0e1d74eb3
Cr-Commit-Position: refs/heads/master@{#13887}
==========

[commit-bot: I haz the power, 2016-08-24 09:45:49]

Patchset 4 (id:??) landed as
https://crrev.com/0aa9d1808b81cc949a66d0fb6adbd1c0e1d74eb3
Cr-Commit-Position: refs/heads/master@{#13887}