Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2263063002: Revert of Add field_trial_default dependency to libjingle_peerconnection (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add field_trial_default dependency to libjingle_peerconnection (patchset #3 id:40001 of https://codereview.webrtc.org/2120673004/ ) Reason for revert: Breaks chromium. Original issue's description: > Add field_trial_default dependency to libjingle_peerconnection > > This is needed for webrtc::field_trial::FindFullName in peerconnection.cc > > NOTRY=True > > Committed: https://crrev.com/a7a01df2aebe7108afad208ccd0341c2f0bc7b3b > Cr-Commit-Position: refs/heads/master@{#13836} TBR=pthatcher@webrtc.org,pthatcher@chromium.org,kjellander@webrtc.org,arlolra@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/86ccd7bfbafc4fd2d86ff05563d52d0aec168d0a Cr-Commit-Position: refs/heads/master@{#13837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/api/api.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sakal
Created Revert of Add field_trial_default dependency to libjingle_peerconnection
4 years, 4 months ago (2016-08-22 07:25:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2263063002/1
4 years, 4 months ago (2016-08-22 07:25:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 07:26:07 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86ccd7bfbafc4fd2d86ff05563d52d0aec168d0a Cr-Commit-Position: refs/heads/master@{#13837}
4 years, 4 months ago (2016-08-22 07:26:18 UTC) #6
sakal
See: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder%20%28dbg%29/builds/16086/steps/compile/logs/stdio androideabi/4.9/../../../../arm-linux-androideabi/bin/ld.gold: error: obj/third_party/libjingle/libjingle.a(field_trial.o): multiple definition of 'webrtc::field_trial::FindFullName(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)' /mnt/data/b/c/b/Android_Builder__dbg_/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld.gold: obj/third_party/webrtc/system_wrappers/field_trial_default/field_trial_default.o: ...
4 years, 4 months ago (2016-08-22 07:29:08 UTC) #7
kjellander_webrtc
4 years, 4 months ago (2016-08-22 14:33:04 UTC) #8
Message was sent while issue was closed.
On 2016/08/22 07:29:08, sakal wrote:
> See:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder%2...
> 
> androideabi/4.9/../../../../arm-linux-androideabi/bin/ld.gold: error:
> obj/third_party/libjingle/libjingle.a(field_trial.o): multiple definition of
> 'webrtc::field_trial::FindFullName(std::__1::basic_string<char,
> std::__1::char_traits<char>, std::__1::allocator<char> > const&)'
>
/mnt/data/b/c/b/Android_Builder__dbg_/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld.gold:
>
obj/third_party/webrtc/system_wrappers/field_trial_default/field_trial_default.o:
> previous definition here

Ah, you pasted the error here :) lgtm

Powered by Google App Engine
This is Rietveld 408576698