Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2262813002:
iOS: add PlistBuddy location to path to avoid build errors (Closed)
|
Created:
4 years, 4 months ago by mpotapov Modified:
4 years, 4 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptioniOS: add PlistBuddy location to path to avoid build errors
On OS X El Capitan, the system location of 'PlistBuddy' is:
"/usr/libexec/PlistBuddy"
and default system path environment variable is:
"PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
NOTRY=True
Committed: https://crrev.com/ff101d6171b02fcdf6e2b9b89482570db3403710
Cr-Commit-Position: refs/heads/master@{#13841}
Patch Set 1 #
Messages
Total messages: 16 (7 generated)
Description was changed from ========== iOS: add PlistBuddy location to path to avoid build errors BUG= ========== to ========== iOS: add PlistBuddy location to path to avoid build errors BUG= ==========
vopatop.skam@gmail.com changed reviewers: + kjellander@webrtc.org
vopatop.skam@gmail.com changed reviewers: + tkchin@webrtc.org
I'm supporting fixing build errors, but can you elaborate on what errors you're getting? Either describe the scenario in the CL description or even better: file a bug at bugs.webrtc.org and reference it like this: BUG=webrtc:<number>
On 2016/08/22 07:17:15, kjellander_webrtc wrote: > I'm supporting fixing build errors, but can you elaborate on what errors you're > getting? Either describe the scenario in the CL description or even better: file > a bug at http://bugs.webrtc.org and reference it like this: BUG=webrtc:<number> I'm getting error: "PlistBuddy: command not found" on OS X El Capitan 10.11.6 (Darwin mbp.local 15.6.0 Darwin Kernel Version 15.6.0: Thu Jun 23 18:25:34 PDT 2016; root:xnu-3248.60.10~1/RELEASE_X86_64 x86_64) For this system location of 'PlistBuddy' is: "/usr/libexec/PlistBuddy" and default system path environment variable is: "PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
Description was changed from ========== iOS: add PlistBuddy location to path to avoid build errors BUG= ========== to ========== iOS: add PlistBuddy location to path to avoid build errors On OS X El Capitan, the system location of 'PlistBuddy' is: "/usr/libexec/PlistBuddy" and default system path environment variable is: "PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin" NOTRY=True ==========
Thanks. That's better. lgtm
On 2016/08/22 09:19:11, kjellander_webrtc wrote: > Thanks. That's better. > > lgtm I updated CL description and will CQ this now.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
On 2016/08/22 09:19:27, kjellander_webrtc wrote: > On 2016/08/22 09:19:11, kjellander_webrtc wrote: > > Thanks. That's better. > > > > lgtm > > I updated CL description and will CQ this now. thanks!
Message was sent while issue was closed.
Description was changed from ========== iOS: add PlistBuddy location to path to avoid build errors On OS X El Capitan, the system location of 'PlistBuddy' is: "/usr/libexec/PlistBuddy" and default system path environment variable is: "PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin" NOTRY=True ========== to ========== iOS: add PlistBuddy location to path to avoid build errors On OS X El Capitan, the system location of 'PlistBuddy' is: "/usr/libexec/PlistBuddy" and default system path environment variable is: "PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin" NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== iOS: add PlistBuddy location to path to avoid build errors On OS X El Capitan, the system location of 'PlistBuddy' is: "/usr/libexec/PlistBuddy" and default system path environment variable is: "PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin" NOTRY=True ========== to ========== iOS: add PlistBuddy location to path to avoid build errors On OS X El Capitan, the system location of 'PlistBuddy' is: "/usr/libexec/PlistBuddy" and default system path environment variable is: "PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin" NOTRY=True Committed: https://crrev.com/ff101d6171b02fcdf6e2b9b89482570db3403710 Cr-Commit-Position: refs/heads/master@{#13841} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ff101d6171b02fcdf6e2b9b89482570db3403710 Cr-Commit-Position: refs/heads/master@{#13841} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
