Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2262683002: WebRtcVideoFrame constructor without transport_frame_id. (Closed)

Created:
4 years, 4 months ago by nisse-webrtc
Modified:
4 years, 4 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pthatcher1, Sergey Ulanov
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRtcVideoFrame constructor without transport_frame_id. Needed as a substitute when eliminating the Copy method. BUG=webrtc:5682 Committed: https://crrev.com/4381700fccc6a1d2f39e1397f4007c6d7f076541 Cr-Commit-Position: refs/heads/master@{#13843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-webrtc
As discussed earlier, this helps eliminating use of the Copy method in applications.
4 years, 4 months ago (2016-08-19 09:36:14 UTC) #2
perkj_webrtc
lgtm
4 years, 4 months ago (2016-08-22 09:17:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2262683002/1
4 years, 4 months ago (2016-08-22 09:38:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 10:54:59 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 10:55:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4381700fccc6a1d2f39e1397f4007c6d7f076541
Cr-Commit-Position: refs/heads/master@{#13843}

Powered by Google App Engine
This is Rietveld 408576698