webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc - Issue 2262213002: Stop increasing loss-based BWE if no feedback is received.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

Issue 2262213002: Stop increasing loss-based BWE if no feedback is received. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

diff --git a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

index 12f86030682d5aebc53b87ceaf376aa7961e3fab..0a15a4123d51b57eee9ddecaff7ac6031ca48b90 100644

--- a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

+++ b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

@@ -89,7 +89,7 @@ TEST(SendSideBweTest, DoesntReapplyBitrateDecreaseWithoutFollowingRemb) {

// Signal heavy loss to go down in bitrate.

bwe.UpdateReceiverBlock(kFractionLoss, kRttMs, 100, now_ms);

// Trigger an update 2 seconds later to not be rate limited.

- now_ms += 2000;

+ now_ms += 1000;

bwe.UpdateEstimate(now_ms);

bwe.CurrentEstimate(&bitrate_bps, &fraction_loss, &rtt_ms);

@@ -107,7 +107,7 @@ TEST(SendSideBweTest, DoesntReapplyBitrateDecreaseWithoutFollowingRemb) {

int last_bitrate_bps = bitrate_bps;

// Trigger an update 2 seconds later to not be rate limited (but it still

// shouldn't update).

- now_ms += 2000;

+ now_ms += 1000;

bwe.UpdateEstimate(now_ms);

bwe.CurrentEstimate(&bitrate_bps, &fraction_loss, &rtt_ms);