webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h - Issue 2262213002: Stop increasing loss-based BWE if no feedback is received.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

Issue 2262213002: Stop increasing loss-based BWE if no feedback is received. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc ('k') | webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

diff --git a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

index dc9de10f7fd997e1dbb8a50bf12e4cf678b63bfe..9529068e4ffd5db455e54783b058c43d42e30ad6 100644

--- a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

+++ b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

@@ -82,7 +82,9 @@ class SendSideBandwidthEstimation {

int64_t last_low_bitrate_log_ms_;

bool has_decreased_since_last_fraction_loss_;

- int64_t time_last_receiver_block_ms_;

+ int64_t last_feedback_ms_;

+ int64_t last_packet_report_ms_;

+ int64_t last_timeout_ms_;

uint8_t last_fraction_loss_;

uint8_t last_logged_fraction_loss_;

int64_t last_round_trip_time_ms_;

@@ -97,6 +99,7 @@ class SendSideBandwidthEstimation {

std::vector<bool> rampup_uma_stats_updated_;

RtcEventLog* event_log_;

int64_t last_rtc_event_log_ms_;

+ bool in_timeout_experiment_;

};

} // namespace webrtc

#endif // WEBRTC_MODULES_BITRATE_CONTROLLER_SEND_SIDE_BANDWIDTH_ESTIMATION_H_