Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: webrtc/pc/rtcpmuxfilter.h

Issue 2260963002: Some cleanup in BaseChannel RTCP mux code. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Clarifying comment. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/rtcpmuxfilter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/rtcpmuxfilter.h
diff --git a/webrtc/pc/rtcpmuxfilter.h b/webrtc/pc/rtcpmuxfilter.h
index 94dc41d980e65d6a85dcda75b0682971e8837e80..91e790d684277406b57343996f2cbdce24e4f694 100644
--- a/webrtc/pc/rtcpmuxfilter.h
+++ b/webrtc/pc/rtcpmuxfilter.h
@@ -21,10 +21,20 @@ class RtcpMuxFilter {
public:
RtcpMuxFilter();
- // Whether the filter is active, i.e. has RTCP mux been properly negotiated.
+ // Whether RTCP mux has been negotiated with a final answer (not provisional).
+ bool IsFullyActive() const;
+
+ // Whether RTCP mux has been negotiated with a provisional answer; this means
+ // a later answer could disable RTCP mux, and so the RTCP transport should
+ // not be disposed yet.
+ bool IsProvisionallyActive() const;
+
+ // Whether the filter is active, i.e. has RTCP mux been properly negotiated,
+ // either with a final or provisional answer.
bool IsActive() const;
- // Make the filter active, regardless of the current state.
+ // Make the filter active (fully, not provisionally) regardless of the
+ // current state. This should be used when an endpoint *requires* RTCP mux.
void SetActive();
// Specifies whether the offer indicates the use of RTCP mux.
« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/rtcpmuxfilter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698