Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: webrtc/pc/rtcpmuxfilter.cc

Issue 2260963002: Some cleanup in BaseChannel RTCP mux code. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Clarifying comment. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/rtcpmuxfilter.h ('k') | webrtc/pc/rtcpmuxfilter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/rtcpmuxfilter.cc
diff --git a/webrtc/pc/rtcpmuxfilter.cc b/webrtc/pc/rtcpmuxfilter.cc
index 86d4b6cd074f7b920fe4b429893ae7097f636df5..715e1e77984ac2fa2b3c1cee280578e2ecce1410 100644
--- a/webrtc/pc/rtcpmuxfilter.cc
+++ b/webrtc/pc/rtcpmuxfilter.cc
@@ -17,10 +17,16 @@ namespace cricket {
RtcpMuxFilter::RtcpMuxFilter() : state_(ST_INIT), offer_enable_(false) {
}
+bool RtcpMuxFilter::IsFullyActive() const {
+ return state_ == ST_ACTIVE;
+}
+
+bool RtcpMuxFilter::IsProvisionallyActive() const {
+ return state_ == ST_SENTPRANSWER || state_ == ST_RECEIVEDPRANSWER;
+}
+
bool RtcpMuxFilter::IsActive() const {
- return state_ == ST_SENTPRANSWER ||
- state_ == ST_RECEIVEDPRANSWER ||
- state_ == ST_ACTIVE;
+ return IsFullyActive() || IsProvisionallyActive();
}
void RtcpMuxFilter::SetActive() {
« no previous file with comments | « webrtc/pc/rtcpmuxfilter.h ('k') | webrtc/pc/rtcpmuxfilter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698