Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2260963002: Some cleanup in BaseChannel RTCP mux code. (Closed)

Created:
4 years, 4 months ago by Taylor Brandstetter
Modified:
4 years, 4 months ago
Reviewers:
skvlad
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Some cleanup in BaseChannel RTCP mux code. Removing a redundant variable used to track whether or not RTCP mux has been fully negotiated. It's RtcpMuxFilter's job to do that, and it already had the state, it just wasn't exposed. Committed: https://crrev.com/23d947dc98246d89479152a4dd8308be4e734f3c Cr-Commit-Position: refs/heads/master@{#13856}

Patch Set 1 #

Patch Set 2 : Removing protected accessor method that's only ever used by the base class. #

Patch Set 3 : Fixing weird formatting and comment text. #

Patch Set 4 : Clarifying comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -46 lines) Patch
M webrtc/pc/channel.h View 1 2 3 3 chunks +18 lines, -15 lines 0 comments Download
M webrtc/pc/channel.cc View 6 chunks +10 lines, -25 lines 0 comments Download
M webrtc/pc/rtcpmuxfilter.h View 1 2 1 chunk +12 lines, -2 lines 0 comments Download
M webrtc/pc/rtcpmuxfilter.cc View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M webrtc/pc/rtcpmuxfilter_unittest.cc View 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
skvlad
lgtm
4 years, 4 months ago (2016-08-22 18:39:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2260963002/60001
4 years, 4 months ago (2016-08-22 18:52:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7598)
4 years, 4 months ago (2016-08-22 19:14:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2260963002/60001
4 years, 4 months ago (2016-08-22 22:51:32 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-22 23:00:37 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 23:00:45 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/23d947dc98246d89479152a4dd8308be4e734f3c
Cr-Commit-Position: refs/heads/master@{#13856}

Powered by Google App Engine
This is Rietveld 408576698