Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: webrtc/modules/rtp_rtcp/test/testFec/test_packet_masks_metrics.cc

Issue 2260803002: Generalize FEC header formatting. (pt. 4) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback response (with accidental rebase). Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/test/testFec/test_packet_masks_metrics.cc
diff --git a/webrtc/modules/rtp_rtcp/test/testFec/test_packet_masks_metrics.cc b/webrtc/modules/rtp_rtcp/test/testFec/test_packet_masks_metrics.cc
index b7c4ef5506b1a11f67e573cfae7d8cacd3edec9a..4c688d7a921fbb95bd79bdf194e77033ff2ca358 100644
--- a/webrtc/modules/rtp_rtcp/test/testFec/test_packet_masks_metrics.cc
+++ b/webrtc/modules/rtp_rtcp/test/testFec/test_packet_masks_metrics.cc
@@ -730,12 +730,13 @@ class FecPacketMaskMetricsTest : public ::testing::Test {
int code_index = 0;
// Maximum number of media packets allowed for the mask type.
const int packet_mask_max = kMaxMediaPackets[fec_mask_type];
- uint8_t* packet_mask = new uint8_t[packet_mask_max * kMaskSizeLBitSet];
+ uint8_t* packet_mask =
+ new uint8_t[packet_mask_max * kUlpfecPacketMaskSizeLBitSet];
danilchap 2016/08/29 12:26:03 kUlpfecMaxPacketMaskSize probably make more sense
brandtr 2016/08/30 07:12:42 Done.
// Loop through codes up to |kMaxMediaPacketsTest|.
for (int num_media_packets = 1; num_media_packets <= kMaxMediaPacketsTest;
num_media_packets++) {
const int mask_bytes_fec_packet =
- (num_media_packets > 16) ? kMaskSizeLBitSet : kMaskSizeLBitClear;
+ internal::PacketMaskSize(num_media_packets);
internal::PacketMaskTable mask_table(fec_mask_type, num_media_packets);
for (int num_fec_packets = 1; num_fec_packets <= num_media_packets;
num_fec_packets++) {

Powered by Google App Engine
This is Rietveld 408576698