Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc

Issue 2260803002: Generalize FEC header formatting. (pt. 4) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
diff --git a/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc b/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
index 697df485874185c890faf036946a30e82158864d..22f3b53039d895f503374da0719226cdaf5b779c 100644
--- a/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
+++ b/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
@@ -107,7 +107,7 @@ TEST(FecTest, MAYBE_FecTest) {
ASSERT_EQ(12, kMaxMediaPackets[1]) << "Max media packets for bursty mode not "
<< "equal to 12.";
- ForwardErrorCorrection fec;
+ ForwardErrorCorrection fec = ForwardErrorCorrection::CreateUlpfec();
ForwardErrorCorrection::PacketList media_packet_list;
std::list<ForwardErrorCorrection::Packet*> fec_packet_list;
ForwardErrorCorrection::ReceivedPacketList to_decode_list;
@@ -238,8 +238,7 @@ TEST(FecTest, MAYBE_FecTest) {
new ForwardErrorCorrection::Packet());
const uint32_t kMinPacketSize = 12;
const uint32_t kMaxPacketSize = static_cast<uint32_t>(
- IP_PACKET_SIZE - 12 - 28 -
- ForwardErrorCorrection::PacketOverhead());
+ IP_PACKET_SIZE - 12 - 28 - fec.MaxPacketOverhead());
media_packet->length = random.Rand(kMinPacketSize,
kMaxPacketSize);
@@ -278,14 +277,14 @@ TEST(FecTest, MAYBE_FecTest) {
}
media_packet_list.back()->data[1] |= 0x80;
- ASSERT_EQ(0, fec.GenerateFec(media_packet_list, protection_factor,
- num_imp_packets, kUseUnequalProtection,
- fec_mask_type, &fec_packet_list))
- << "GenerateFec() failed";
+ ASSERT_EQ(0, fec.EncodeFec(media_packet_list, protection_factor,
+ num_imp_packets, kUseUnequalProtection,
+ fec_mask_type, &fec_packet_list))
+ << "EncodeFec() failed";
ASSERT_EQ(num_fec_packets, fec_packet_list.size())
<< "We requested " << num_fec_packets << " FEC packets, but "
- << "GenerateFec() produced " << fec_packet_list.size();
+ << "EncodeFec() produced " << fec_packet_list.size();
memset(media_loss_mask, 0, sizeof(media_loss_mask));
uint32_t media_packet_idx = 0;
@@ -393,8 +392,8 @@ TEST(FecTest, MAYBE_FecTest) {
}
}
}
- ASSERT_EQ(0, fec.DecodeFec(&to_decode_list,
- &recovered_packet_list))
+ ASSERT_EQ(0,
+ fec.DecodeFec(&to_decode_list, &recovered_packet_list))
<< "DecodeFec() failed";
ASSERT_TRUE(to_decode_list.empty())
<< "Received packet list is not empty.";

Powered by Google App Engine
This is Rietveld 408576698