Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2260183002: Revert of Cleanup of the AudioDeviceBuffer class (Closed)

Created:
4 years, 4 months ago by henrika_webrtc
Modified:
4 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Cleanup of the AudioDeviceBuffer class (patchset #6 id:100001 of https://codereview.webrtc.org/2256833003/ ) Reason for revert: Seems to break an external client. Original issue's description: > Cleanup of the AudioDeviceBuffer class. > > WebRTC works on 10ms buffer sizes in both directions but this class has contained > support for any size (with some limits) and for changes on the fly. It makes no sense to maintain such code and we have no tests to test it. This CL ensures that only 10ms audio buffers are supported and that nothing can be changed on the fly. > > It also updates the style to follow the Google C++ style guide. > > Finally, I remove very old (not tested and not maintained) support for file > handling since the code is never used. It was more or less dead code. > > BUG=NONE > R=magjed@webrtc.org > > Committed: https://crrev.com/cf327b45b9f5738950d4fca2b6a7b6030d508cdf > Cr-Commit-Position: refs/heads/master@{#13833} TBR=magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://crrev.com/d7a89dbe8bfe2d1091ab7dda11737442ae832a90 Cr-Commit-Position: refs/heads/master@{#13834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -212 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.h View 4 chunks +42 lines, -56 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 13 chunks +212 lines, -156 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
henrika_webrtc
Created Revert of Cleanup of the AudioDeviceBuffer class
4 years, 4 months ago (2016-08-19 15:09:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2260183002/1
4 years, 4 months ago (2016-08-19 15:09:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 15:09:28 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 15:09:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7a89dbe8bfe2d1091ab7dda11737442ae832a90
Cr-Commit-Position: refs/heads/master@{#13834}

Powered by Google App Engine
This is Rietveld 408576698