Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2260173002: Disable the software noise suppressor on iOS devices (Closed)

Created:
4 years, 4 months ago by peah-webrtc
Modified:
4 years, 4 months ago
Reviewers:
the sun, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable the software noise suppressor on iOS devices as that functionality is always present in the hardware. BUG=webrtc:6231 Committed: https://crrev.com/4905f068781cec64307bedcb36351da4f8c119b2 Cr-Commit-Position: refs/heads/master@{#13839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
peah-webrtc
4 years, 4 months ago (2016-08-19 12:51:15 UTC) #3
henrika_webrtc
LGTM
4 years, 4 months ago (2016-08-19 13:39:05 UTC) #4
the sun
lgtm
4 years, 4 months ago (2016-08-22 07:46:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2260173002/1
4 years, 4 months ago (2016-08-22 08:07:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 08:58:55 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 08:59:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4905f068781cec64307bedcb36351da4f8c119b2
Cr-Commit-Position: refs/heads/master@{#13839}

Powered by Google App Engine
This is Rietveld 408576698