Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2259783002:
Reland of Adding audio to video_quality_test. (Closed)
|
Created:
4 years, 4 months ago by minyue-webrtc Modified:
4 years, 4 months ago CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, perkj_webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReland of Adding audio to video_quality_test.
The original commit was https://codereview.webrtc.org/2136573002/.
BUG=
Committed: https://crrev.com/732086609177d0e657cc7bc96737db7117e72cec
Cr-Commit-Position: refs/heads/master@{#13818}
Patch Set 1 #Patch Set 2 : fixing struct initialization. #
Messages
Total messages: 25 (14 generated)
Description was changed from ========== Revert "Revert of Adding audio to video_quality_test. (patchset #10 id:230001 of https://codereview.webrtc.org/2136573002/ )" This reverts commit f095012dc207a044ea82ea322cb9600eb66aa500. BUG= ========== to ========== Reland of Adding audio to video_quality_test. The original commit was https://codereview.webrtc.org/2136573002/. BUG= ==========
minyue@webrtc.org changed reviewers: + stefan@webrtc.org, terelius@webrtc.org
The CQ bit was unchecked by minyue@webrtc.org
The CQ bit was checked by minyue@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by minyue@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
Patchset #3 (id:40001) has been deleted
Patchset #3 (id:60001) has been deleted
Hi,
Please take a look at this again. I think the reversion was because
Params.ss which contains a std::vector cannot be assigned of value {} on some
builder. {{}} may work but I think it would be better to assign explicitly.
PS 1 is the same as before reverted, and PS 2 has the latest changes.
On 2016/08/18 09:18:29, minyue-webrtc wrote:
> Hi,
>
> Please take a look at this again. I think the reversion was because
> Params.ss which contains a std::vector cannot be assigned of value {} on some
> builder. {{}} may work but I think it would be better to assign explicitly.
>
> PS 1 is the same as before reverted, and PS 2 has the latest changes.
Seemed to failt o apply the patch on linux_rel?
On 2016/08/18 09:33:44, stefan-webrtc (holmer) wrote:
> On 2016/08/18 09:18:29, minyue-webrtc wrote:
> > Hi,
> >
> > Please take a look at this again. I think the reversion was because
> > Params.ss which contains a std::vector cannot be assigned of value {} on
some
> > builder. {{}} may work but I think it would be better to assign explicitly.
> >
> > PS 1 is the same as before reverted, and PS 2 has the latest changes.
>
> Seemed to failt o apply the patch on linux_rel?
And where did it fail before? Was it not caught by trybots?
On 2016/08/18 09:35:16, stefan-webrtc (holmer) wrote:
> On 2016/08/18 09:33:44, stefan-webrtc (holmer) wrote:
> > On 2016/08/18 09:18:29, minyue-webrtc wrote:
> > > Hi,
> > >
> > > Please take a look at this again. I think the reversion was because
> > > Params.ss which contains a std::vector cannot be assigned of value {} on
> some
> > > builder. {{}} may work but I think it would be better to assign
explicitly.
> > >
> > > PS 1 is the same as before reverted, and PS 2 has the latest changes.
> >
> > Seemed to failt o apply the patch on linux_rel?
>
> And where did it fail before? Was it not caught by trybots?
not caused by trybot, but here
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%...
On 2016/08/18 09:36:39, minyue-webrtc wrote:
> On 2016/08/18 09:35:16, stefan-webrtc (holmer) wrote:
> > On 2016/08/18 09:33:44, stefan-webrtc (holmer) wrote:
> > > On 2016/08/18 09:18:29, minyue-webrtc wrote:
> > > > Hi,
> > > >
> > > > Please take a look at this again. I think the reversion was because
> > > > Params.ss which contains a std::vector cannot be assigned of value {} on
> > some
> > > > builder. {{}} may work but I think it would be better to assign
> explicitly.
> > > >
> > > > PS 1 is the same as before reverted, and PS 2 has the latest changes.
> > >
> > > Seemed to failt o apply the patch on linux_rel?
> >
> > And where did it fail before? Was it not caught by trybots?
>
> not caused by trybot, but here
>
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%...
ok, assuming the fix works, lgtm
On 2016/08/18 13:16:09, stefan-webrtc (holmer) wrote:
> On 2016/08/18 09:36:39, minyue-webrtc wrote:
> > On 2016/08/18 09:35:16, stefan-webrtc (holmer) wrote:
> > > On 2016/08/18 09:33:44, stefan-webrtc (holmer) wrote:
> > > > On 2016/08/18 09:18:29, minyue-webrtc wrote:
> > > > > Hi,
> > > > >
> > > > > Please take a look at this again. I think the reversion was because
> > > > > Params.ss which contains a std::vector cannot be assigned of value {}
on
> > > some
> > > > > builder. {{}} may work but I think it would be better to assign
> > explicitly.
> > > > >
> > > > > PS 1 is the same as before reverted, and PS 2 has the latest changes.
> > > >
> > > > Seemed to failt o apply the patch on linux_rel?
> > >
> > > And where did it fail before? Was it not caught by trybots?
> >
> > not caused by trybot, but here
> >
>
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%...
>
> ok, assuming the fix works, lgtm
but make sure the red bots are ok
The CQ bit was checked by minyue@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Reland of Adding audio to video_quality_test. The original commit was https://codereview.webrtc.org/2136573002/. BUG= ========== to ========== Reland of Adding audio to video_quality_test. The original commit was https://codereview.webrtc.org/2136573002/. BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Reland of Adding audio to video_quality_test. The original commit was https://codereview.webrtc.org/2136573002/. BUG= ========== to ========== Reland of Adding audio to video_quality_test. The original commit was https://codereview.webrtc.org/2136573002/. BUG= Committed: https://crrev.com/732086609177d0e657cc7bc96737db7117e72cec Cr-Commit-Position: refs/heads/master@{#13818} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/732086609177d0e657cc7bc96737db7117e72cec Cr-Commit-Position: refs/heads/master@{#13818} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
