Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2259513002: Nil out EAGLContext explicitly on RTCEAGLVideoView dealloc. (Closed)

Created:
4 years, 4 months ago by tkchin_webrtc
Modified:
4 years, 4 months ago
Reviewers:
Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kthelgason, magjed_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Nil out EAGLContext explicitly on RTCEAGLVideoView dealloc. Theoretical fix to address some EAGLContext issues from other UIImageViews that could be active. NOTRY=True BUG= Committed: https://crrev.com/41a32874727160d3309ba5b1783a4c87a7fd9d64 Cr-Commit-Position: refs/heads/master@{#13806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M webrtc/sdk/objc/Framework/Classes/RTCEAGLVideoView.m View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkchin_webrtc
4 years, 4 months ago (2016-08-17 19:09:11 UTC) #3
Chuck
lgtm
4 years, 4 months ago (2016-08-17 19:13:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2259513002/1
4 years, 4 months ago (2016-08-17 22:54:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 23:03:03 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 23:03:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41a32874727160d3309ba5b1783a4c87a7fd9d64
Cr-Commit-Position: refs/heads/master@{#13806}

Powered by Google App Engine
This is Rietveld 408576698