Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: webrtc/api/statscollector.h

Issue 2259283002: Refactor certificate stats collection, added SSLCertificateStats. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Another unittest for the case of certificate chains using fake certificates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/statscollector.cc » ('j') | webrtc/base/sslidentity_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 void ClearUpdateStatsCacheForTest(); 84 void ClearUpdateStatsCacheForTest();
85 85
86 private: 86 private:
87 friend class StatsCollectorTest; 87 friend class StatsCollectorTest;
88 88
89 // Overridden in unit tests to fake timing. 89 // Overridden in unit tests to fake timing.
90 virtual double GetTimeNow(); 90 virtual double GetTimeNow();
91 91
92 bool CopySelectedReports(const std::string& selector, StatsReports* reports); 92 bool CopySelectedReports(const std::string& selector, StatsReports* reports);
93 93
94 // Helper method for AddCertificateReports.
95 StatsReport* AddOneCertificateReport(
96 const rtc::SSLCertificate* cert, const StatsReport* issuer);
97
98 // Helper method for creating IceCandidate report. |is_local| indicates 94 // Helper method for creating IceCandidate report. |is_local| indicates
99 // whether this candidate is local or remote. 95 // whether this candidate is local or remote.
100 StatsReport* AddCandidateReport(const cricket::Candidate& candidate, 96 StatsReport* AddCandidateReport(const cricket::Candidate& candidate,
101 bool local); 97 bool local);
102 98
103 // Adds a report for this certificate and every certificate in its chain, and 99 // Adds a report for this certificate and every certificate in its chain, and
104 // returns the leaf certificate's report. 100 // returns the leaf certificate's report (|cert|'s report).
105 StatsReport* AddCertificateReports(const rtc::SSLCertificate* cert); 101 StatsReport* AddCertificateReports(const rtc::SSLCertificate* cert);
106 102
107 StatsReport* AddConnectionInfoReport(const std::string& content_name, 103 StatsReport* AddConnectionInfoReport(const std::string& content_name,
108 int component, int connection_id, 104 int component, int connection_id,
109 const StatsReport::Id& channel_report_id, 105 const StatsReport::Id& channel_report_id,
110 const cricket::ConnectionInfo& info); 106 const cricket::ConnectionInfo& info);
111 107
112 void ExtractDataInfo(); 108 void ExtractDataInfo();
113 void ExtractSessionInfo(); 109 void ExtractSessionInfo();
114 void ExtractVoiceInfo(); 110 void ExtractVoiceInfo();
(...skipping 29 matching lines...) Expand all
144 // TODO(tommi): We appear to be holding on to raw pointers to reference 140 // TODO(tommi): We appear to be holding on to raw pointers to reference
145 // counted objects? We should be using scoped_refptr here. 141 // counted objects? We should be using scoped_refptr here.
146 typedef std::vector<std::pair<AudioTrackInterface*, uint32_t> > 142 typedef std::vector<std::pair<AudioTrackInterface*, uint32_t> >
147 LocalAudioTrackVector; 143 LocalAudioTrackVector;
148 LocalAudioTrackVector local_audio_tracks_; 144 LocalAudioTrackVector local_audio_tracks_;
149 }; 145 };
150 146
151 } // namespace webrtc 147 } // namespace webrtc
152 148
153 #endif // WEBRTC_API_STATSCOLLECTOR_H_ 149 #endif // WEBRTC_API_STATSCOLLECTOR_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/statscollector.cc » ('j') | webrtc/base/sslidentity_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698