webrtc/media/engine/fakewebrtcvideocapturemodule.h - Issue 2258933003: Refactor WebRtcVideoCapturer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/fakewebrtcvideocapturemodule.h

Issue 2258933003: Refactor WebRtcVideoCapturer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/fakewebrtcvideocapturemodule.h

diff --git a/webrtc/media/engine/fakewebrtcvideocapturemodule.h b/webrtc/media/engine/fakewebrtcvideocapturemodule.h

index 2bc715b1e1fc630557508d4838a620e98a85b3d0..d81597858b9873c5d53c8ed4534a17585f42ff02 100644

--- a/webrtc/media/engine/fakewebrtcvideocapturemodule.h

+++ b/webrtc/media/engine/fakewebrtcvideocapturemodule.h

@@ -75,7 +75,7 @@ class FakeWebRtcVideoCaptureModule : public webrtc::VideoCaptureModule {

return -1; // not implemented

}

bool SetApplyRotation(bool enable) override {

- return false; // not implemented

+ return true; // ignored

perkj_webrtc 2016/08/19 13:08:59 why this change?

nisse-webrtc 2016/08/19 13:30:02 Because the change to have VideoCaptureListener us

}

bool GetApplyRotation() override {

return true; // Rotation compensation is turned on.