Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2258583004: Restart capture session if needed on active. (Closed)

Created:
4 years, 4 months ago by tkchin_webrtc
Modified:
4 years, 4 months ago
Reviewers:
magjed1, Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Restart capture session if needed on active. We've seen some cases of nonrecoverable runtime error when entering the foreground. This is a theoretical fix to see if we can restart after willEnterForeground in didBecomeActive instead. NOTRY=True BUG= Committed: https://crrev.com/118402520fec3bb1e05349d40c70c28f0b232a06 Cr-Commit-Position: refs/heads/master@{#13903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkchin_webrtc
4 years, 4 months ago (2016-08-18 05:25:32 UTC) #4
Chuck
lgtm
4 years, 4 months ago (2016-08-18 15:45:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2258583004/1
4 years, 4 months ago (2016-08-24 18:18:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 19:06:00 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 19:06:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/118402520fec3bb1e05349d40c70c28f0b232a06
Cr-Commit-Position: refs/heads/master@{#13903}

Powered by Google App Engine
This is Rietveld 408576698