Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2258543002: WebRtcIlbcfix_Smooth: Fix UBSan fuzzer bug (left shift of 1 by 31 overflows) (Closed)

Created:
4 years, 4 months ago by kwiberg-webrtc
Modified:
4 years, 4 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRtcIlbcfix_Smooth: Fix UBSan fuzzer bug (left shift of 1 by 31 overflows) scale1 == 31 if and only if w10 == 0. So even though 1 << scale1 overflows, we know that the result of the multiplication should be 0. Handle that case. BUG=chromium:615818 Committed: https://crrev.com/7f82fc988ded707247f317019215e4abdd6fe19f Cr-Commit-Position: refs/heads/master@{#13847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_coding/codecs/ilbc/smooth.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 4 months ago (2016-08-17 17:40:43 UTC) #2
tlegrand-webrtc
lgtm
4 years, 4 months ago (2016-08-22 13:13:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2258543002/1
4 years, 4 months ago (2016-08-22 13:16:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 14:43:46 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 14:44:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f82fc988ded707247f317019215e4abdd6fe19f
Cr-Commit-Position: refs/heads/master@{#13847}

Powered by Google App Engine
This is Rietveld 408576698