Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2258523005: Style cleanup in UpdateTmmbr: (Closed)

Created:
4 years, 4 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Style cleanup in UpdateTmmbr: function names style updated, unused return type removed. Comment style fixed, redundant comments removed. pass-by-pointer parameter changed to pass-by-value because can't be nullptr any more. NOTRY=true BUG=webrtc:5565 Committed: https://crrev.com/853ecb21f77a4758e465b889f645f89e955c539a Cr-Commit-Position: refs/heads/master@{#13848}

Patch Set 1 #

Patch Set 2 : pass-by-reference -> pass-by-value #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -44 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 3 chunks +11 lines, -19 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danilchap
4 years, 4 months ago (2016-08-22 06:31:33 UTC) #4
philipel
lgtm
4 years, 4 months ago (2016-08-22 15:08:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2258523005/40001
4 years, 4 months ago (2016-08-22 15:14:20 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-22 15:26:21 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 15:26:31 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/853ecb21f77a4758e465b889f645f89e955c539a
Cr-Commit-Position: refs/heads/master@{#13848}

Powered by Google App Engine
This is Rietveld 408576698