Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2258103003: iOS H264VideoToolBoxEncoder: Stop scaling native CVPixelBuffers (Closed)

Created:
4 years, 4 months ago by magjed_webrtc
Modified:
4 years, 4 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS H264VideoToolBoxEncoder: Stop scaling native CVPixelBuffers If the input to H264VideoToolBoxEncoder is a native CVPixelBuffer and the quality scaler requests scaling, we fall back to a slow path where the buffer is converted from NV12 to I420 on the CPU and then uploaded to a native CVPixelBuffer again. It turns out this scaling is not needed and that the H264VideoToolBoxEncoder can handle the scaling internally. BUG=b/30939444 Committed: https://crrev.com/81774526986d350d751fbdef72d7e50da134e56d Cr-Commit-Position: refs/heads/master@{#13835}

Patch Set 1 #

Patch Set 2 : Remove enable_scaling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -45 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm View 1 8 chunks +28 lines, -45 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
magjed_webrtc
Zeke - please take a look. It will still scale when the input is I420, ...
4 years, 4 months ago (2016-08-19 14:07:49 UTC) #3
tkchin_webrtc
On 2016/08/19 14:07:49, magjed_webrtc wrote: > Zeke - please take a look. It will still ...
4 years, 4 months ago (2016-08-19 17:07:12 UTC) #4
magjed_webrtc
I removed the enable_scaling_ logic in the latest patch. This will turn on the quality ...
4 years, 4 months ago (2016-08-20 17:44:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2258103003/20001
4 years, 4 months ago (2016-08-20 17:44:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-20 17:53:30 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 17:53:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81774526986d350d751fbdef72d7e50da134e56d
Cr-Commit-Position: refs/heads/master@{#13835}

Powered by Google App Engine
This is Rietveld 408576698