Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Unified Diff: webrtc/media/BUILD.gn

Issue 2257753002: GN: Fix errors when some variables are set to non-default values. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/BUILD.gn
diff --git a/webrtc/media/BUILD.gn b/webrtc/media/BUILD.gn
index f45974c86d4b2e4c157441be285aa4c07fc48ff8..a95ab23d9e1d60ff497334ef94132477ba4eeb7c 100644
--- a/webrtc/media/BUILD.gn
+++ b/webrtc/media/BUILD.gn
@@ -141,6 +141,7 @@ source_set("rtc_media") {
]
}
+ include_dirs = []
if (rtc_build_libyuv) {
deps += [ "$rtc_libyuv_dir" ]
public_deps = [
@@ -152,7 +153,7 @@ source_set("rtc_media") {
}
if (rtc_build_usrsctp) {
- include_dirs = [
+ include_dirs += [
# TODO(jiayl): move this into the public_configs of
# //third_party/usrsctp/BUILD.gn.
"//third_party/usrsctp/usrsctplib",
@@ -222,6 +223,8 @@ if (rtc_include_tests) {
source_set("rtc_unittest_main") {
testonly = true
+ include_dirs = []
+ public_deps = []
deps = []
sources = [
"base/fakemediaengine.h",
@@ -250,9 +253,7 @@ if (rtc_include_tests) {
if (rtc_build_libyuv) {
deps += [ "$rtc_libyuv_dir" ]
- public_deps = [
- "$rtc_libyuv_dir",
- ]
+ public_deps += [ "$rtc_libyuv_dir" ]
} else {
# Need to add a directory normally exported by libyuv.
include_dirs += [ "$rtc_libyuv_dir/include" ]
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698