Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: webrtc/base/BUILD.gn

Issue 2257753002: GN: Fix errors when some variables are set to non-default values. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/media/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index ed40a42280fab33fdcb009aa6ca05233b6a962d9..9bffa97da4635baed23920f7dc55d0b10d116b3e 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -81,7 +81,7 @@ if (is_linux && !build_with_chromium) {
}
}
-if (rtc_build_ssl == 0) {
+if (!rtc_build_ssl) {
config("external_ssl_library") {
assert(rtc_ssl_root != "",
"You must specify rtc_ssl_root when rtc_build_ssl==0.")
@@ -506,7 +506,7 @@ static_library("rtc_base") {
if (rtc_build_json) {
deps += [ "//third_party/jsoncpp" ]
} else {
- include_dirs += [ rtc_jsoncpp_root ]
+ include_dirs = [ "$rtc_jsoncpp_root" ]
# When defined changes the include path for json.h to where it is
# expected to be when building json outside of the standalone build.
@@ -525,7 +525,7 @@ static_library("rtc_base") {
if (rtc_build_ssl) {
deps += [ "//third_party/boringssl" ]
} else {
- configs += [ "external_ssl_library" ]
+ configs += [ ":external_ssl_library" ]
}
if (is_android) {
« no previous file with comments | « no previous file | webrtc/media/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698