Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2257753002: GN: Fix errors when some variables are set to non-default values. (Closed)

Created:
4 years, 4 months ago by kjellander_webrtc
Modified:
4 years, 4 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix errors when some variables are set to non-default values. BUG=webrtc:6223 TESTED=Passing generation with: gn gen out/Default --args='rtc_build_expat=false rtc_build_json=false rtc_build_libyuv=false' NOTRY=True Committed: https://crrev.com/ec5c9061c8025edc34b0f498e39861c8df5dbb48 Cr-Commit-Position: refs/heads/master@{#13827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M webrtc/base/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/BUILD.gn View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kjellander_webrtc
4 years, 4 months ago (2016-08-18 09:56:10 UTC) #2
ehmaldonado_webrtc
On 2016/08/18 09:56:10, kjellander_webrtc wrote: lgtm
4 years, 4 months ago (2016-08-18 14:39:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2257753002/1
4 years, 4 months ago (2016-08-19 06:47:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7545)
4 years, 4 months ago (2016-08-19 07:00:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2257753002/1
4 years, 4 months ago (2016-08-19 07:51:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 08:07:34 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 08:07:36 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec5c9061c8025edc34b0f498e39861c8df5dbb48
Cr-Commit-Position: refs/heads/master@{#13827}

Powered by Google App Engine
This is Rietveld 408576698